Workspace aware ContentGraph / Node followup

[mhsdesign]

Followup for #5028

• dont access foreign projections via sql: !!! FEATURE: Bind ContentGraph to workspace #5028 (comment)
  • !!! TASK: Add workspace content stream mapping to content graph projection #5096
• avoid workspace finder being used in command handling CommandHandlingDependencies::getWorkspaceFinder (and getContentStreamFinder) -> obsolete now that its one projection
• clearly document and explain subgraph instance caching and memory cache and lifetime -> at the moment we disabled all caches and moved the subgraph cache to the cr registry
  -> Define ContentGraph memory cache flushing #5039
  • or even refactor this behaviour? !!! FEATURE: Bind ContentGraph to workspace #5028 (comment)
• make content graph projection first level citizen and remove ContentGraphFinder::getByWorkspaceNameAndContentStreamId by passing the content graph factory directly to the CommandHandlingDependencies -> will be fixe via !!! TASK: Introduce first level content repository projection #5272
  • maybe remove the ContentGraphFinder thing or rename it?
• remove or 'fix' `ContentGraphInterface::countNodes -> will be moved out of the content graph with !!! TASK: Introduce first level content repository projection #5272
  • iExpectTheSubgraphProjectionToConsistOfExactlyNodes is a dub of iExpectTheGraphProjectionToConsistOfExactlyNodes -> nope one is for subgraph and other is globally
  • see comment !!! FEATURE: Bind ContentGraph to workspace #5028 (comment)
• remove reflection in tests !!! FEATURE: Bind ContentGraph to workspace #5028 (comment) and Make ContentRepositoryServiceFactoryInterface internal, and remove usages in Neos.Neos #4634
• remove cs id from tests Adjust behat test to only operate on workspace names  #5034
• requireContentStreamDoes not exist constraint is not covered by tests: !!! FEATURE: Bind ContentGraph to workspace #5028 (comment)
• discuss getContentGraph nullable or throwing exception?
  -> the expectation is that the workspace does exist and it would just make the code using it more complex. Also there is likely no fallback option available meaning we will mostly throw an exception again, so this might as well be the default.
• move new classes so they are not first level! -> will be fixe via !!! TASK: Introduce first level content repository projection #5272

Things for #5042

• add workspace name and content repository id and remove cs id in node aggregate
• remove json serialize 9.0 subgraph should not be json serializeable  #5051

[mhsdesign]

older notes just for reference :)

• Userland should not need to operate on cs ids
  -> Events must operate on cs ids
• getSubgraph arguments
  • WorkspaceName → internally resolved to cs id and will do lookup instantly (CACHE)
    -> "refresh" mapping manually or implicit through handle? FEATURE: Highlevel Workspace API #4943 (comment)
  • DimensionSpacePoint
  • VisibilityConstraints
• NodeFactory::mapNodeRowToNode must accept WorkspaceName and ContentStreamId from outside.
  • must accept ContentStreamId as parameter see TASK: Pass ContentStreamId to NodeFactory #4941
  • must accept WorkspaceName as parameter
• => Extend SubgraphIdentity
  • add workspaceName
  • add @internal annotation
    • and to its getters like getIdentity FEATURE 4327 - Expose a subgraph's identity #4678
• command handlers should still operate on cs ids via getSubgraphByIdentity - INTERNAL
  • by that both apis always pass the WorkspaceName
• Node should know its
  • ContentRepositoryId
  • WorkspaceName
    • NOT: ContentSubgraphIdentity.
    • NOT: ContentStreamId
  • DimensionSpacePoint it was fetched from
  • VisibilityConstraints
    -> so it can be passed as single instance and eel helpers can fetch parents e.t.c in the same context
  • OriginDimensionSpacePoint (as before)
• WorkspaceName::fromString() must be stricter without colons (so that we could allow in the future for extension, e.g. WorkspaceName::detached(ContentStreamid $csId) (with an internal representation like “cs:”)

further todos from christian an me:

• add workspaceName <-> contentStreamId table to content graph projection
• add workspaceName -> contentStreamId lookup to ContentGraph::getSubgraph() (with runtime cache in the ContentGraph – the same workspace will resolve to the same CS ID in one request, maybe reset runtime cache via markStale())
• rewrite ContentGraph::find* queries to use workspaceName instead of contentStreamId (IMO it's totally fine to join the workspaceName <-> cs id table here for those queries. Alternatively we could add a dedicated lookup + runtime cache)
• remove SubgraphIdentity

Afterwards we have to find out whether there are places that need to be able to override the workspace name -> cs id mapping for tests or CR constraints. If so we could either:

• Add a separate, internal, ContentGraph::getSubgraphInternal() – but that would be dangerous because it is part of the public interface (even if marked internal)
• Introduce a ContentsubgraphFactoryInterface that can be used via CR service
• Provide a way to hook into the runtime cache, e.g. $contentGraph->dangerousSetContentStreamIdForWorkspaceNameFooBar(...)
• Extract workspaceName<->cs id mapping to external service that can be replaced/hooked into

[kitsunet]

What is still missing for this now?

[mhsdesign]

Indeed most things are resolved with the merge of #5096 and the leftovers are either outdated or will be fixed via #5272