Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Backend Login screen no longer shows site-name #5234

Closed
1 task done
c4ll-m3-j4ck opened this issue Sep 3, 2024 · 1 comment · Fixed by #5236
Closed
1 task done

BUG: Backend Login screen no longer shows site-name #5234

c4ll-m3-j4ck opened this issue Sep 3, 2024 · 1 comment · Fixed by #5236
Assignees
@crydotsnake
Labels
9.0 Bug Good first issue

Comments

@c4ll-m3-j4ck
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

There are two places in Neos.Neos:View.Login that reference props.site.name.value. Site::getName() returns a string however so there is no value-object to unwrap.

The login screen /neos no longer shows the name of the site but simply "Login to"

Expected Behavior

The login screen should show the correct text "Login to {sitename}"

Steps To Reproduce

No response

Environment

- Flow: 9.0.0-beta13
- Neos: 9.0.0-beta13
- PHP: 8.3

Anything else?

No response
@crydotsnake crydotsnake self-assigned this Sep 5, 2024
@crydotsnake crydotsnake mentioned this issue Sep 5, 2024
Merged
6 tasks
@crydotsnake
Copy link
Member

Hello @c4ll-m3-j4ck !

Thanks for reporting.

I created a PR.

dlubitz added a commit that referenced this issue Sep 5, 2024
@dlubitz
Merge pull request #5236 from crydotsnake/bugfix/5243/show-site-name-…
f70178b 
…in-login-screen

BUGFIX: #5234 Display site-name on neos login view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crydotsnake crydotsnake

Labels
9.0 Bug Good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUGFIX: #5234 Display site-name on neos login view crydotsnake/neos-development-collection
3 participants
@c4ll-m3-j4ck @dlubitz @crydotsnake