Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: #5234 Display site-name on neos login view #5236

Merged
merged 1 commit into from
Sep 5, 2024
Merged

BUGFIX: #5234 Display site-name on neos login view #5236

merged 1 commit into from
Sep 5, 2024

Conversation

crydotsnake
Copy link
Member

Upgrade instructions

None

Review instructions

Resolves: #5234

Displays the site-name title in the Neos Login screen.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@crydotsnake
Copy link
Member Author

crydotsnake commented Sep 5, 2024 •
edited
Loading

@mhsdesign I saw you changed the Neos.Neos:View.Login prototype the last time in june. Did you maybe forgot to change those lines?

The commit was: 3518a34

kdambekalns
kdambekalns approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 by 👀

dlubitz
dlubitz approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works.

@dlubitz dlubitz merged commit f70178b into neos:9.0 Sep 5, 2024
9 checks passed
@mhsdesign
Copy link
Member

thanks good catch thats on me :D

@mhsdesign mhsdesign mentioned this pull request Sep 9, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubitz dlubitz dlubitz approved these changes

@kdambekalns kdambekalns kdambekalns approved these changes

@mhsdesign mhsdesign Awaiting requested review from mhsdesign

Assignees
No one assigned
Labels
9.0 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Backend Login screen no longer shows site-name
4 participants
@crydotsnake @mhsdesign @kdambekalns @dlubitz