FEATURE: workspace aware Node (introduce new NodeAdress)
#5042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 tasks
mhsdesign
force-pushed
the
task/workspaceAwareNode
branch
from
393ebd1
to
e2c79b6
Compare
mhsdesign
force-pushed
the
task/workspaceAwareNode
branch
from
1a7705e
to
e6fa114
Compare
kitsunet
reviewed
May 11, 2024
Neos.ContentGraph.DoctrineDbalAdapter/src/Domain/Repository/NodeFactory.php
Outdated
Show resolved
Hide resolved
mhsdesign
force-pushed
the
task/workspaceAwareNode
branch
from
ab6e154
to
f893301
Compare
6 tasks
mhsdesign
force-pushed
the
task/workspaceAwareNode
branch
from
9c073e5
to
5e630d1
Compare
mhsdesign
commented
May 13, 2024
| @@ -204,5 +204,9 @@ public function retrieveNodePath(NodeAggregateId $nodeAggregateId): AbsoluteNode | |||
| */ | |||
| public function countNodes(): int; | |||
|
|
|||
| public function jsonSerialize(): ContentSubgraphIdentity; | |||
| /** | |||
| * @deprecated will be removed before Neos 9 release | |||
The nodeadress was added 6 years ago without the concept of multiple crs. Its usages will be replaced by the new node attached node address
This adds a value object to the core encapsulating all identifiers to identify/fetch a single node.
…eprecate `node.nodeAggregateId`
mhsdesign
force-pushed
the
task/workspaceAwareNode
branch
from
5c1e131
to
95ea686
Compare
bwaidelich
approved these changes
May 13, 2024
Neos.ContentRepository.Core/Classes/SharedModel/Node/NodeAddress.php
Outdated
Show resolved
Hide resolved
Neos.ContentRepository.Core/Classes/SharedModel/Node/NodeAddress.php
Outdated
Show resolved
Hide resolved
…hape Co-authored-by: Bastian Waidelich <[email protected]>
mhsdesign
force-pushed
the
task/workspaceAwareNode
branch
from
c08f471
to
4ab3ec9
Compare
mhsdesign
commented
May 13, 2024
Neos.ContentRepository.Core/Classes/Projection/ContentGraph/ContentSubgraphInterface.php
Outdated
Show resolved
Hide resolved
15 tasks
kitsunet
reviewed
May 13, 2024
Neos.ContentGraph.DoctrineDbalAdapter/src/Domain/Repository/ContentGraph.php
Show resolved
Hide resolved
kitsunet
reviewed
May 13, 2024
Neos.ContentGraph.PostgreSQLAdapter/src/Domain/Repository/NodeFactory.php
Show resolved
Hide resolved
kitsunet
reviewed
May 13, 2024
Neos.ContentRepository.Core/Classes/DimensionSpace/DimensionSpacePoint.php
Show resolved
Hide resolved
kitsunet
reviewed
May 13, 2024
kitsunet
reviewed
May 13, 2024
|
Some comments but overall looks good. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces initial draft at #4868
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions