Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: 9.0 Node access flow query operations #5046

Merged
merged 3 commits into from
May 13, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented May 12, 2024

see #5022

Introduces

  • ${q(node).id()}
  • ${q(node).label()}
  • ${q(node).nodeTypeName()}

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign force-pushed the feature/nodeAccessFlowQueryOperations branch from 15337f0 to 84bc7c6 Compare May 12, 2024 11:38
@mhsdesign mhsdesign force-pushed the feature/nodeAccessFlowQueryOperations branch 2 times, most recently from 01f90dd to 27fe1e9 Compare May 12, 2024 13:29
@mhsdesign
Copy link
Member Author

Its to be discussed if there should be a FlowQuery for fetching the nodes name via ${q(node).name()} vs ${node.nodeName.value}

@kitsunet
Copy link
Member

${q(node).name()} I wouldn't mind that, node.name is something I have seen around in the wild from time to time.

@mhsdesign
Copy link
Member Author

Fine as discussed with @kitsunet @bwaidelich there will be no preferred way to access the nodes name but it will be node.name.value or node.nodeName.value

@mhsdesign mhsdesign force-pushed the feature/nodeAccessFlowQueryOperations branch from 6c61483 to c18ec8a Compare May 13, 2024 12:09
@mhsdesign mhsdesign force-pushed the feature/nodeAccessFlowQueryOperations branch 2 times, most recently from 14a8010 to 6bcbfaa Compare May 13, 2024 12:19
@mhsdesign mhsdesign force-pushed the feature/nodeAccessFlowQueryOperations branch from 6bcbfaa to 540c605 Compare May 13, 2024 12:23
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading – thanks!

@mhsdesign mhsdesign merged commit 162680f into neos:9.0 May 13, 2024
8 checks passed
@mhsdesign mhsdesign deleted the feature/nodeAccessFlowQueryOperations branch May 13, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants