TASK: Make single-field Value Objects stringable #5241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the magic `__toString()` method to relevant core value objects that represent a single string value. Note: This also adds and configures a PHPStan rule that disallows implicit casting in for those Related: #5239
Base automatically changed from
feature/5239-stringable-value-objects
to
9.0
September 6, 2024 15:54
|
I fell like one question is left unanswered. Now with stringcastable things again in fusion do we still need the newly introduced flowqueries? 🤯
because I just updated all our rector migrations 🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦 |
6 tasks
|
I do kinda like them still because suddenly we could change the API without affecting fusion. |
|
On the otherhand i think its really valuable to have one way of doing it instead of 2 or multiple ones. There should be always one clear solution so that people dont have to come up with too many guidelines for their own projects. I mean neos was always opinionated so why not this time as well? |
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Oct 8, 2024
…query operations with neos#5241 value object were made string-able, so they are simply usable in fusion after all. Previously flowquery operations were introduced to not have to do the manual string cast via `.value` in `node.nodeTypeName.value` and similar. The label flowquery operation was introduced in the same run but now we reconsidered that flowquery should mostly be used for traversal and the only real final operation is get(). For this reason we also discourage the property operation now. The negative performance aspect of 8.3 of needlesly resolving all reference nodes by calling `node.properties.title` is dated as now only real properties are ever in the result set.
6 tasks
neos-bot
pushed a commit
to neos/contentrepository-nodeaccess
that referenced
this pull request
Oct 14, 2024
…query operations with neos/neos-development-collection#5241 value object were made string-able, so they are simply usable in fusion after all. Previously flowquery operations were introduced to not have to do the manual string cast via `.value` in `node.nodeTypeName.value` and similar. The label flowquery operation was introduced in the same run but now we reconsidered that flowquery should mostly be used for traversal and the only real final operation is get(). For this reason we also discourage the property operation now. The negative performance aspect of 8.3 of needlesly resolving all reference nodes by calling `node.properties.title` is dated as now only real properties are ever in the result set.
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Oct 14, 2024
…query operations with neos/neos-development-collection#5241 value object were made string-able, so they are simply usable in fusion after all. Previously flowquery operations were introduced to not have to do the manual string cast via `.value` in `node.nodeTypeName.value` and similar. The label flowquery operation was introduced in the same run but now we reconsidered that flowquery should mostly be used for traversal and the only real final operation is get(). For this reason we also discourage the property operation now. The negative performance aspect of 8.3 of needlesly resolving all reference nodes by calling `node.properties.title` is dated as now only real properties are ever in the result set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the magic
__toString()method in relevant core value objects that represent a single string value.Note: This also adds and configures a PHPStan rule that disallows implicit casting in for those
Related: #5239
Reverts parts of #4156