FEATURE: User workspaces #5119
Closed
FEATURE: User workspaces #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
reviewed
Jun 3, 2024
| UserId::fromString($this->persistenceManager->getIdentifierByObject($user)) | ||
| ) | ||
| ); | ||
| $this->workspaceProvider->providePrimaryPersonalWorkspaceForUser($siteDetectionResult->contentRepositoryId, $user); |
There was a problem hiding this comment.
i thought the provide pattern would be used to instantiate the workspace at the first place actually used. This just eagerly instantiates the workspace - which WILL not be the case for the edge case being logged in already and switching sites - so i would probably prefer to remove the functionality from this service?
|
I think this can be closed with the introduction of #5146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the concept of user workspaces on a higher level via the workspace provider
Upgrade instructions
none
Review instructions
none
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions