FEATURE: Extract workspace metadata and user-assignment to Neos #3838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser-assignment-to-neos
…orkspace-metadata-and-user-assignment-to-neos
mhsdesign
changed the title
mhsdesign
previously requested changes
Sep 27, 2024
| @@ -14,7 +14,7 @@ | |||
| "require": { | |||
| "neos/flow-development-collection": "9.0.x-dev as 9.0", | |||
|
|
|||
| "neos/neos-development-collection": "9.0.x-dev as 9.0", | |||
| "neos/neos-development-collection": "feature/4726-extract-workspace-metadata-and-user-assignment-to-neos-dev as 9.0", | |||
Comment on lines
338
to
343
| $command['contentRepositoryId'] = $contentRepositoryId->value; | ||
| $command['siteId'] = $this->nodeService->deserializeNodeAddress( | ||
| $siteNodeAddress = $this->nodeService->deserializeNodeAddress( | ||
| $command['siteId'], | ||
| $contentRepositoryId | ||
| )->nodeAggregateId->value; | ||
| $command = DiscardChangesInSite::fromArray($command); |
There was a problem hiding this comment.
i know this currently looks weird but this was just introduced by Bernhard and Wilhelm and we plan - as the comment says @todo send from UI - to send the array shape directly from the neos ui and then call DiscardChangesInSite::fromArray just to have type safety. Eventually each command will have its own proper command handler etc but right now its in an in between state. So i would like to keep the usages to the commands.
There was a problem hiding this comment.
reintroduced the usages. Otherwise we would also have ugly conflicts with #3858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counter-part to neos/neos-development-collection#5146
Related: neos/neos-development-collection#4726