NEST3 triggers warnings when compiled with Clang 9

[heplesser]

NEST3 triggers a number of warnings when compiled with Clang 9, mainly in recording_device.h, but also

/Users/plesser/NEST/code/src_nest3/nestkernel/node_manager.cpp:383:10: warning: local variable 'nodecollection' will be copied despite being returned by name [-Wreturn-std-move]
  return nodecollection;
         ^~~~~~~~~~~~~~
/Users/plesser/NEST/code/src_nest3/nestkernel/node_manager.cpp:383:10: note: call 'std::move' explicitly to avoid copying
  return nodecollection;
         ^~~~~~~~~~~~~~
         std::move(nodecollection)

[ikitayama]

Could you do the same with trunk? To see they go away?

…

On Tue, Jan 14, 2020 at 7:30 Hans Ekkehard Plesser ***@***.***> wrote: NEST3 triggers a number of warnings when compiled with Clang 9, mainly in recording_device.h, but also /Users/plesser/NEST/code/src_nest3/nestkernel/node_manager.cpp:383:10: warning: local variable 'nodecollection' will be copied despite being returned by name [-Wreturn-std-move] return nodecollection; ^~~~~~~~~~~~~~ /Users/plesser/NEST/code/src_nest3/nestkernel/node_manager.cpp:383:10: note: call 'std::move' explicitly to avoid copying return nodecollection; ^~~~~~~~~~~~~~ std::move(nodecollection) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1391?email_source=notifications&email_token=AAHLBZ7CTFQN55NYNE5R5MTQ5TTOPA5CNFSM4KGJZY72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IF4NVGA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHLBZ6A4CPVX37JTQFHVS3Q5TTOPANCNFSM4KGJZY7Q> .

[heplesser]

@ikitayama These warnings were NEST-3 specific.

[ikitayama]

I meant that you could try Clang’s development branch called trunk just to see if they go away.

…

On Tue, Jan 14, 2020 at 19:41 Hans Ekkehard Plesser < ***@***.***> wrote: @ikitayama <https://github.com/ikitayama> These warnings were NEST-3 specific. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1391?email_source=notifications&email_token=AAHLBZ6QULMXACHOPVTOYO3Q5WJFPA5CNFSM4KGJZY72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI4EMTA#issuecomment-574113356>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHLBZ3PJFWX76YOC54OB53Q5WJFPANCNFSM4KGJZY7Q> .

[ikitayama]

With the trunk Clang as of this writing, I don't see the warning @heplesser reported on Arm.

[ikitayama]

What about the build time? Quick still on x86?

[ikitayama]

What about the build time? Quick still on x86?

Sorry I take it back, I was using a Debug Clang that I really should've avoided.

[ikitayama]

Upstream often likes to fix a bug in trunk, that's why I was suggesting to use the Clang 10 candidate.

[heplesser]

@ikitayama I fear I caused some confusion with the way I worded the issue description: The problem was not in Clang, but in the NEST code. Clang pointed out some slight weaknesses in the NEST code which g++ had not warned about. Sorry for the confusion. The weaknesses are now fixed in the nest-3 branch.