Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link PyNEST functions in documentaton #2010

Merged
merged 15 commits into from
Aug 16, 2021

Conversation

jessica-mitchell
Copy link
Contributor

@jessica-mitchell jessica-mitchell commented Apr 13, 2021

This PR provides links to the API functions in the documentation, specifically restructuredtext files in doc/userdoc.
There are still files to update in the nest-3 guides, but waiting for #1929 to be merged, so this is still incomplete.

Note: set() and get() methods are in both SynapseCollection and NodeCollection class, so the class name needs to be included in the link. (This is mentioned in styleguide #1986 )

Resolves #1878

@jessica-mitchell jessica-mitchell added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Apr 13, 2021
@jessica-mitchell jessica-mitchell marked this pull request as draft April 13, 2021 08:48
@jessica-mitchell jessica-mitchell marked this pull request as ready for review June 24, 2021 07:42
@jougs
Copy link
Contributor

jougs commented Jul 20, 2021

@steffengraber, @jasperalbers: could you please review? If you don't have time right now, please quickly indicate this, so we can try to find other reviewers. Thanks!

@jougs jougs added this to the NEST 3.1 milestone Jul 20, 2021
Copy link
Contributor

@jasperalbers jasperalbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, very useful! I left a few comments.

@@ -18,13 +18,13 @@ target nodes that will be connected in an all-to-all fashion.
Each call to the function will establish the connectivity between pre-
and post-synaptic populations according to a certain pattern or
rule. The desired pattern is specified by simply stating the rule name
as third argument to ``Connect()``, or by setting the key `rule` in
the `connectivity specification` dictionary ``conn_spec`` alongside
as third argument to ``Connect()``, or by setting the key ``rule`` in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this occurrence of Connect() rather than :py:func:.Connect intended? You use the new way in lines 12 and 38 while the old one is used here and in line 27.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was trying to only link each function once per paragraph or section.

doc/userdoc/guides/connection_management.rst Outdated Show resolved Hide resolved
doc/userdoc/guides/connection_management.rst Outdated Show resolved Hide resolved
@jessica-mitchell
Copy link
Contributor Author

Hi @jasperalbers I have addressed your comments, could you please take another look? thanks!

Copy link
Contributor

@steffengraber steffengraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Really helpful! Found only one little thing.


Collocated synapses
~~~~~~~~~~~~~~~~~~~
It is now possible to create connections with several synapses simultaneously. The different synapse dictionaries will
then be applied to each source-target pair. To create these collocated synapses, ``CollocatedSynapses()`` must be used
as the `syn_spec` argument of ``Connect``, instead of the usual syn_spec dictionary argument. The constructor
then be applied to each source-target pair. To create these collocated synapses, :py:func:`.CollocatedSynapses` must be used
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be :py:class:.CollocatedSynapses``

Copy link
Contributor

@steffengraber steffengraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1 from my side.

Copy link
Contributor

@jasperalbers jasperalbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jougs
Copy link
Contributor

jougs commented Aug 2, 2021

@jessica-mitchell: I'll merge as soon as you fix the conflicts ;-)

@jougs
Copy link
Contributor

jougs commented Aug 16, 2021

@jessica-mitchell: can you maybe merge master again? If that does not solve the static code check problems, I can have a closer look.

@jougs
Copy link
Contributor

jougs commented Aug 16, 2021

I'm merging even thought the one static check still fails. I'll fix that in master.

@jougs jougs merged commit a5c7bfb into nest:master Aug 16, 2021
@jessica-mitchell jessica-mitchell deleted the link-pynest-api-docs branch April 17, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Automatically link PyNEST functions
4 participants