Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example demonstrating spike-based simulations of Pong #2393

Merged
merged 28 commits into from
Sep 28, 2022

Conversation

krachbumm3nte
Copy link
Contributor

A NEST-based simulator for training spiking networks to play the classic game Pong, based on: https://github.com/electronicvisions/model-sw-pong

Permission to use part of the original code in the NEST repository has been granted by Timo Wunderlich and Eric Müller (representing "Electronic Vision(s)")

setting as draft until #2384 is merged

@jessica-mitchell jessica-mitchell self-requested a review May 16, 2022 07:23
@terhorstd terhorstd added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 27, 2022
@terhorstd
Copy link
Contributor

@krachbumm3nte, thanks for also adding this example. Just FYI: I just merged #2384, unblocking this one.

@krachbumm3nte krachbumm3nte marked this pull request as ready for review August 25, 2022 10:57
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krachbumm3nte Thanks for the contribution, this looks really good. I have a few minor points that need addressing. I also want to include this example in the examples/index page but this requires some rearranging of the topics, so I will create a PR against your branch.

pynest/examples/pong/run_simulations.py Outdated Show resolved Hide resolved
pynest/examples/pong/run_simulations.py Outdated Show resolved Hide resolved
pynest/examples/pong/run_simulations.py Outdated Show resolved Hide resolved
pynest/examples/pong/run_simulations.py Outdated Show resolved Hide resolved
pynest/examples/pong/run_simulations.py Outdated Show resolved Hide resolved
pynest/examples/pong/networks.py Outdated Show resolved Hide resolved
pynest/examples/pong/run_simulations.py Outdated Show resolved Hide resolved
pynest/examples/pong/run_simulations.py Outdated Show resolved Hide resolved
pynest/examples/pong/pong.py Outdated Show resolved Hide resolved
pynest/examples/pong/networks.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krachbumm3nte lgtm!

Copy link
Contributor

@JanVogelsang JanVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor corrections needed (see PR on your repo), then this PR can be merged imo.

krachbumm3nte and others added 3 commits September 27, 2022 13:52
Pretty much just minor changes and efforts to make the codebase more consistent
@JanVogelsang
Copy link
Contributor

Wouldn't have thought that PyCharm doesn't indent lines according to PEP8, thanks for correcting the indentation.
Looks good to me now!

@hakonsbm hakonsbm merged commit 8028a79 into nest:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants