-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example demonstrating spike-based simulations of Pong #2393
Conversation
93dfaf2
to
bc65eea
Compare
…e/nest-simulator into pong_pynest_example
@krachbumm3nte, thanks for also adding this example. Just FYI: I just merged #2384, unblocking this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krachbumm3nte Thanks for the contribution, this looks really good. I have a few minor points that need addressing. I also want to include this example in the examples/index page but this requires some rearranging of the topics, so I will create a PR against your branch.
Co-authored-by: jessica-mitchell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @krachbumm3nte lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor corrections needed (see PR on your repo), then this PR can be merged imo.
Pretty much just minor changes and efforts to make the codebase more consistent
Wouldn't have thought that PyCharm doesn't indent lines according to PEP8, thanks for correcting the indentation. |
A NEST-based simulator for training spiking networks to play the classic game Pong, based on: https://github.com/electronicvisions/model-sw-pong
Permission to use part of the original code in the NEST repository has been granted by Timo Wunderlich and Eric Müller (representing "Electronic Vision(s)")
setting as draft until #2384 is merged