Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print NetBox version when running upgrade.sh #14507

Closed
markkuleinio opened this issue Dec 13, 2023 · 2 comments · Fixed by #14547
Closed

Print NetBox version when running upgrade.sh #14507

markkuleinio opened this issue Dec 13, 2023 · 2 comments · Fixed by #14547
Assignees
@markkuleinio
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@markkuleinio
Copy link
Contributor

markkuleinio commented Dec 13, 2023 •
edited
Loading

NetBox version

v3.7-beta1

Feature type

New functionality

Proposed functionality

When running upgrade.sh it would be beneficial to see what is the actual NetBox version that is being prepared.

Something like

echo "NetBox version is $(grep ^VERSION netbox/netbox/settings.py | cut -d\' -f2)"
NetBox version is 3.7-beta1

would maybe be enough somewhere in the beginning of upgrade.sh.

Use case

Sometimes there is confusion when symlinking or pulling the versions here and there and running upgrade.sh, what is the actual codebase that is being activated.

Database changes

None

External dependencies

None
@markkuleinio markkuleinio added the type: feature Introduction of new functionality to the application label Dec 13, 2023
@DanSheps
Copy link
Member

I would add, it might be wise too break until there is input after that (unless running non-interactively).

@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Dec 15, 2023
@markkuleinio
Copy link
Contributor Author

I can submit the PR. I can add the pause in interactive mode (let's discuss in the PR if something needs adjusting).

@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Dec 16, 2023
@markkuleinio markkuleinio mentioned this issue Dec 16, 2023
Merged
jeremystretch added a commit that referenced this issue Dec 21, 2023
@jeremystretch
Changelog for #14507, #14538, #14549, #14560, #14575
c289dda
@jeremystretch jeremystretch mentioned this issue Dec 27, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markkuleinio markkuleinio

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NetBox version output in upgrade.sh markkuleinio/netbox
4 participants
@abhi1693 @DanSheps @jeremystretch @markkuleinio