Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #14538 - Add available_at_site filter #14541

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Closes #14538 - Add available_at_site filter #14541

merged 3 commits into from
Dec 21, 2023

Conversation

DanSheps
Copy link
Member

Closes: #14538

  • Add filter available_at_site for VLAN filterset
  • Add queryset filter for get_for_site (called by available_at_site method)

jeremystretch
jeremystretch requested changes Dec 15, 2023
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a test for the new filter in ipam/tests/test_filtersets.py.

jeremystretch
jeremystretch approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanSheps!

@jeremystretch jeremystretch merged commit 8dfec7e into develop Dec 21, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 14538-add_available_at_site_filter branch December 21, 2023 20:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add available_at_site filter for VLAN Model
2 participants
@DanSheps @jeremystretch