-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1186: extract DNS flags rcode field and stringify it #451
NETOBSERV-1186: extract DNS flags rcode field and stringify it #451
Conversation
msherif1234
commented
Jul 11, 2023
•
edited
Loading
edited
- try compress out unused fields to reduce flp generated map size
- for dns tracker extract and decode response code so it can be used as UI filter
@msherif1234: This pull request references NETOBSERV-1186 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #451 +/- ##
==========================================
- Coverage 62.85% 62.69% -0.16%
==========================================
Files 96 96
Lines 6916 6970 +54
==========================================
+ Hits 4347 4370 +23
- Misses 2325 2356 +31
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more.
|
899e4f2
to
e06771d
Compare
/ok-to-test |
New image: quay.io/netobserv/flowlogs-pipeline:86f203e. It will expire after two weeks. |
Thanks @msherif1234 ! That works perfectly with front end. A small change will be needed for |
e06771d
to
ec2fdf7
Compare
/ok-to-test |
New image: quay.io/netobserv/flowlogs-pipeline:a6271d3. It will expire after two weeks. |
ec2fdf7
to
db148b4
Compare
db148b4
to
1ee346e
Compare
@msherif1234: This pull request references NETOBSERV-1186 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
New image: quay.io/netobserv/flowlogs-pipeline:084ecfb. It will expire after two weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @msherif1234
/approve |
Signed-off-by: msherif1234 <[email protected]>
1ee346e
to
cfb2b10
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak, msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |