Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1186 DNS respond codes #355

Closed
wants to merge 30 commits into from
Closed

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jul 12, 2023

This PR rely on netobserv/flowlogs-pipeline#451 that expose DNS response codes as strings and introduce optionnal fields in GenericMap

It's based on #324 so we should merge it first.
Take a look at b0e5796 commit for related changes

It adds the related column and filter + manage the optionnal fields

image
image

@openshift-ci
Copy link

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #355 (ae89d0f) into main (38f4cfc) will decrease coverage by 0.50%.
The diff coverage is 55.01%.

@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   57.92%   57.43%   -0.50%     
==========================================
  Files         150      154       +4     
  Lines        6665     7065     +400     
  Branches      797      866      +69     
==========================================
+ Hits         3861     4058     +197     
- Misses       2588     2771     +183     
- Partials      216      236      +20     
Flag Coverage Δ
uitests 59.12% <64.41%> (+0.28%) ⬆️
unittests 52.71% <37.07%> (-2.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/handler/lokiclientmock/loki_client_mock.go 0.00% <0.00%> (ø)
pkg/model/fields/fields.go 100.00% <ø> (ø)
web/src/api/ipfix.ts 100.00% <ø> (ø)
web/src/api/loki.ts 100.00% <ø> (ø)
web/src/components/__tests-data__/config.ts 100.00% <ø> (ø)
...components/dropdowns/overview-display-dropdown.tsx 68.42% <ø> (ø)
web/src/components/dropdowns/scope-dropdown.tsx 31.81% <ø> (ø)
...components/dropdowns/topology-display-dropdown.tsx 47.36% <ø> (ø)
web/src/components/filters/filters-toolbar.tsx 59.59% <ø> (+0.22%) ⬆️
web/src/components/messages/loki-error.tsx 24.28% <ø> (ø)
... and 43 more

... and 1 file with indirect coverage changes

@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 13, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:ece8e2f

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=ece8e2f make set-plugin-image

@msherif1234
Copy link
Contributor

#356 included this PR

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpinsonneau
Copy link
Contributor Author

replaced by #356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants