Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align default tagging #713

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 16, 2024

cc @OlivierCazade same PR than here netobserv/network-observability-operator#769

  • I'm aligning the default tag to what we do also in the other repos, using main by default

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.35%. Comparing base (df4bbeb) to head (e0f1043).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
- Coverage   65.38%   65.35%   -0.03%     
==========================================
  Files         108      108              
  Lines        6960     6960              
==========================================
- Hits         4551     4549       -2     
- Misses       2099     2100       +1     
- Partials      310      311       +1     
Flag Coverage Δ
unittests 65.35% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@jotak jotak changed the title Fix builds with podman; align default tagging Align default tagging Sep 18, 2024
@jotak
Copy link
Member Author

jotak commented Sep 18, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Sep 18, 2024

@jotak: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 36d2ee0 into netobserv:main Sep 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants