-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix podman builds #769
Fix podman builds #769
Conversation
Well I get this warning
So that's probably wrong... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
- Coverage 66.90% 66.78% -0.13%
==========================================
Files 74 74
Lines 8658 8658
==========================================
- Hits 5793 5782 -11
- Misses 2462 2468 +6
- Partials 403 408 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
7aabd86
to
d13054d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR tested with docker |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@OlivierCazade do you know what we need to check to make sure this won't break anything?