Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podman builds #769

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 11, 2024

@OlivierCazade do you know what we need to check to make sure this won't break anything?

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Sep 11, 2024
@jotak
Copy link
Member Author

jotak commented Sep 11, 2024

Well I get this warning

[Warning] one or more build args were not consumed: [BUILDPLATFORM]

So that's probably wrong...

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.78%. Comparing base (6160075) to head (d13054d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
- Coverage   66.90%   66.78%   -0.13%     
==========================================
  Files          74       74              
  Lines        8658     8658              
==========================================
- Hits         5793     5782      -11     
- Misses       2462     2468       +6     
- Partials      403      408       +5     
Flag Coverage Δ
unittests 66.78% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlivierCazade
Copy link
Contributor

PR tested with docker

@jotak
Copy link
Member Author

jotak commented Sep 11, 2024

/approve

Copy link

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants