Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix podman builds #596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix podman builds #596

wants to merge 1 commit into from

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 16, 2024

same as netobserv/network-observability-operator#769 , with some extra cleaning

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Sep 16, 2024
Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.01%. Comparing base (693d236) to head (70e63c1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   56.01%   56.01%           
=======================================
  Files         193      193           
  Lines        9479     9479           
  Branches     1213     1213           
=======================================
  Hits         5310     5310           
  Misses       3792     3792           
  Partials      377      377           
Flag Coverage Δ
uitests 57.72% <ø> (ø)
unittests 51.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jotak
Copy link
Member Author

jotak commented Oct 4, 2024

@OlivierCazade I rebased this PR, you already fixed the initial problem but this is still doing a bit a cleanup (removing unused arguments)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants