Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the same MTU for the NSC internal interface as the base interface has #514

Closed
ljkiraly opened this issue Mar 8, 2022 · 4 comments · Fixed by #515
Closed

Set the same MTU for the NSC internal interface as the base interface has #514

ljkiraly opened this issue Mar 8, 2022 · 4 comments · Fixed by #515
Assignees
@ljkiraly
Labels
bug Something isn't working

Comments

@ljkiraly
Copy link
Contributor

ljkiraly commented Mar 8, 2022

Description

In case of vlan remote mechanism the MTU of the interface injected in NSC Pod is not adjusted.

Possible solution

Fetch the base interface MTU and include it into the connection.Context.
@ljkiraly ljkiraly added the bug Something isn't working label Mar 8, 2022
@ljkiraly ljkiraly self-assigned this Mar 8, 2022
ljkiraly added a commit to Nordix/nsm-sdk-vpp that referenced this issue Mar 8, 2022
@ljkiraly
Set the same MTU for the NSC internal interface as the base interface…
c3d90d8 
… has

Closes: networkservicemesh#514

Signed-off-by: Laszlo Kiraly <[email protected]>
@ljkiraly ljkiraly mentioned this issue Mar 8, 2022
Merged
@edwarnicke
Copy link
Member

@ljkiraly Last I checked... the MTU on the interface in the NSC was set as the smallest MTU along the path, where the MTU for tunneled interfaces was calculated by subtracting overhead from the underlying interface. What are you seeing that differs from that?

@ljkiraly
Copy link
Contributor Author

ljkiraly commented Mar 8, 2022 •
edited
Loading

@edwarnicke Yes, for vxlan mechanism the MTU is set correctly. I missed to adjust the MTU in case of remote vlan mechanism. I'm unsure if the MTU should be decreased by the VLAN tag size (4 bytes) for the interface injected in NSC Pod.

@ljkiraly
Copy link
Contributor Author

ljkiraly commented Mar 9, 2022

Based on kernel documentation the MTU does not include link layer header overhead.

@edwarnicke
Copy link
Member

@ljkiraly You are correct.

ljkiraly added a commit to Nordix/nsm-sdk-vpp that referenced this issue Mar 14, 2022
@ljkiraly
Set the same MTU for the NSC internal interface as the base interface…
bb5ec7d 
… has

Closes: networkservicemesh#514

Signed-off-by: Laszlo Kiraly <[email protected]>
edwarnicke pushed a commit that referenced this issue Mar 14, 2022
@ljkiraly
Set the same MTU for the NSC internal interface as the base interface…
10353b8 
… has (#515)

Closes: #514

Signed-off-by: Laszlo Kiraly <[email protected]>
@edwarnicke edwarnicke moved this to Done in Release 1.3.0 Mar 14, 2022
@LionelJouin LionelJouin moved this to ✅ Done in Meridio Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljkiraly ljkiraly

Labels
bug Something isn't working
Projects
Release 1.3.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set the same MTU for the NSC internal interface as the base interface Nordix/nsm-sdk-vpp
2 participants
@edwarnicke @ljkiraly