Set the same MTU for the NSC internal interface as the base interface #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwarnicke
reviewed
Mar 11, 2022
| @@ -35,6 +38,9 @@ const ( | |||
| ) | |||
|
|
|||
| func setVPPL2MTU(ctx context.Context, conn *networkservice.Connection, vppConn api.Connection, isClient bool) error { | |||
| if vlan.ToMechanism(conn.GetMechanism()) != nil { | |||
| return nil | |||
| } | |||
There was a problem hiding this comment.
Could you help me to understand this... I don't quite follow.
There was a problem hiding this comment.
Hello @edwarnicke,
The forwarder is the client on a VLAN remote mechanism connection. The mechanism/vlan/mtu chain client fetch the MTU of the sub-interface and set its value in ConnectionContext. The Connectioncontext client chain element should not set any MTU value since it's fetched from this interface and is already set (more than that in case of VLAN remote mechanism the API call will fail since the sub-interface is not a hw-interface).
I moved this statement to pkg/networkservice/connectioncontext/mtu/client.go.
… has Closes: networkservicemesh#514 Signed-off-by: Laszlo Kiraly <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Mar 14, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#515 Commit: 10353b8 Author: Laszlo Kiraly Date: 2022-03-14 16:01:53 +0100 Message: - Set the same MTU for the NSC internal interface as the base interface has (#515) Closes: #514 Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Mar 14, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#515 Commit: 10353b8 Author: Laszlo Kiraly Date: 2022-03-14 16:01:53 +0100 Message: - Set the same MTU for the NSC internal interface as the base interface has (#515) Closes: #514 Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Mar 14, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#515 Commit: 10353b8 Author: Laszlo Kiraly Date: 2022-03-14 16:01:53 +0100 Message: - Set the same MTU for the NSC internal interface as the base interface has (#515) Closes: #514 Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Mar 14, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#515 Commit: 10353b8 Author: Laszlo Kiraly Date: 2022-03-14 16:01:53 +0100 Message: - Set the same MTU for the NSC internal interface as the base interface has (#515) Closes: #514 Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Mar 14, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#515 Commit: 10353b8 Author: Laszlo Kiraly Date: 2022-03-14 16:01:53 +0100 Message: - Set the same MTU for the NSC internal interface as the base interface has (#515) Closes: #514 Signed-off-by: NSMBot <[email protected]>
This was referenced Mar 14, 2022
Merged
denis-tingaikin
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Mar 14, 2022
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main PR link: networkservicemesh/sdk-vpp#515 Commit: 10353b8 Author: Laszlo Kiraly Date: 2022-03-14 16:01:53 +0100 Message: - Set the same MTU for the NSC internal interface as the base interface has (#515) Closes: #514 Signed-off-by: NSMBot <[email protected]> * Update vpp image version Signed-off-by: Artem Glazychev <[email protected]> Co-authored-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Mar 14, 2022
…d-forwarder-vpp@main PR link: networkservicemesh/cmd-forwarder-vpp#520 Commit: 86c33ca Author: Artem Glazychev Date: 2022-03-14 23:33:40 +0700 Message: - Update vpp image version (#520) * Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main PR link: networkservicemesh/sdk-vpp#515 Commit: 10353b8 Author: Laszlo Kiraly Date: 2022-03-14 16:01:53 +0100 Message: - Set the same MTU for the NSC internal interface as the base interface has (#515) Closes: #514 Signed-off-by: NSMBot <[email protected]> * Update vpp image version Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #514
Signed-off-by: Laszlo Kiraly [email protected]