Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Huawei VRP display versiontemplate #1205

Merged

Conversation

cuong-nguyenduy
Copy link
Contributor

Some platforms use Huawei instead of HUAWEI

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT
  • Template: huawei_vrp_display_version.textfsm
  • OS: Huawei VRP
  • Command: display version
SUMMARY

Some platforms use Huawei instead of HUAWEI in their model information. This PR includes Huawei to the start of the model information, and relevant test

Some platforms use `Huawei` instead of `HUAWEI`
This could break backward compatibility
Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending tests.

@jvanderaa jvanderaa merged commit 6a585f2 into networktocode:master Oct 26, 2022
@jvanderaa
Copy link
Contributor

Thank you @cuong-nguyenduy for the contribution!

guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants