Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cisco NXOS display inventory #1206

Merged

Conversation

cuong-nguyenduy
Copy link
Contributor

Reordering the order of Regex such that the more specific will be used before the more generic ones

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT
  • Template: cisco_nxos_show_inventory.textfsm
  • OS: Cisco NXOS
  • Command: show inventory
SUMMARY

Reordering the regexes such that the more specific ones will be used before the more generic ones.
Add test entry to cover such case

Reordering the order of Regex such that the more specific will be used before the more generic ones
Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending tests.

@jvanderaa jvanderaa merged commit d4897a4 into networktocode:master Oct 26, 2022
@jvanderaa
Copy link
Contributor

Thank you @cuong-nguyenduy for the update!

@whitej6
Copy link
Contributor

whitej6 commented Nov 17, 2022

@cuong-nguyenduy can you reach out to me via [email protected] This PR (and #1205 ) were considered part of hacktoberfest and Network to Code would like to show our appreciation for your contributions.

guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
Reordering the order of Regex such that the more specific will be used before the more generic ones
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
Reordering the order of Regex such that the more specific will be used before the more generic ones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants