-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend tests for bboxes datasets #246
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 14 14
Lines 883 883
=======================================
Hits 881 881
Misses 2 2 ☔ View full report in Codecov by Sentry. |
87384b7
to
9730284
Compare
cabb3bc
to
4ceae4c
Compare
90b2682
to
96d8259
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done on extending the tests! I particularly like how you also test subsets of data with the selectors.
I just had some cosmetics/pedantic comments.
Co-authored-by: Niko Sirmpilatze <[email protected]>
for more information, see https://pre-commit.ci
Quality Gate passedIssues Measures |
Description
What is this PR
Why is this PR needed?
To extend existing tests to bboxes datasets.
What does this PR do?
This PR covers the tests from the
logging
andreport
modules.There are changes to the dataset validators tests too, because of refactoring a fixture involved in them.
References
How has this PR been tested?
Tests pass locally and in CI.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: