Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tests for bboxes datasets #246

Merged
merged 42 commits into from
Aug 27, 2024
Merged

Extend tests for bboxes datasets #246

merged 42 commits into from
Aug 27, 2024

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Jul 25, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
To extend existing tests to bboxes datasets.

What does this PR do?
This PR covers the tests from the logging and report modules.

There are changes to the dataset validators tests too, because of refactoring a fixture involved in them.

References

How has this PR been tested?

Tests pass locally and in CI.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • [ n/a ] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (38246d9) to head (789d26f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          14       14           
  Lines         883      883           
=======================================
  Hits          881      881           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig force-pushed the smg/extend-tests-for-bboxes-ds branch from cabb3bc to 4ceae4c Compare August 7, 2024 08:07
@sfmig sfmig force-pushed the smg/extend-tests-for-bboxes-ds branch from 90b2682 to 96d8259 Compare August 7, 2024 13:43
@sfmig sfmig marked this pull request as ready for review August 19, 2024 10:00
@sfmig sfmig requested a review from niksirbi August 19, 2024 10:00
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on extending the tests! I particularly like how you also test subsets of data with the selectors.

I just had some cosmetics/pedantic comments.

tests/conftest.py Outdated Show resolved Hide resolved
tests/test_unit/test_logging.py Show resolved Hide resolved
tests/test_unit/test_logging.py Show resolved Hide resolved
tests/test_unit/test_reports.py Show resolved Hide resolved
tests/test_unit/test_reports.py Outdated Show resolved Hide resolved
tests/test_unit/test_reports.py Outdated Show resolved Hide resolved
tests/test_unit/test_reports.py Show resolved Hide resolved
tests/test_unit/test_reports.py Outdated Show resolved Hide resolved
@sfmig sfmig linked an issue Aug 27, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Aug 27, 2024

@sfmig sfmig added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 3ee5836 Aug 27, 2024
12 checks passed
@lochhh lochhh deleted the smg/extend-tests-for-bboxes-ds branch August 28, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend tests to cover bounding boxes datasets
2 participants