-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify and expand filtering tests for bboxes #267
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 14 14
Lines 883 883
=======================================
Hits 881 881
Misses 2 2 ☔ View full report in Codecov by Sentry. |
a4fe242
to
93ec8da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is an error in scaling the time-unit for frames vs seconds in the interpolation test, so pleas have another look at that.
Otherwise, I'm on-board with this refactoring 👍🏼
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
What is this PR
Why is this PR needed?
We want to ensure the filtering methods work for bboxes datasets.
What does this PR do?
References
Overflow from PR #246
How has this PR been tested?
Tests pass locally and in CI.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
I reviewed the docstrings to check references to poses data but only did a minor change.
I changed some references from "filtering" to "smoothing" for consistency within the docstring, but open to other opinions.
Checklist: