Windows CI builds are broken - $ENV{SHELL} path expands Win-style

[alexsavulescu]

Most probably an update of the VM image.

Issue:

[ 18%] Building CXX object external/iv/src/lib/CMakeFiles/interviews.dir/InterViews/slider.cpp.obj
The system cannot find the file specified
make[2]: *** [src/nrniv/CMakeFiles/nrnversion_h.dir/build.make:70: src/nrniv/CMakeFiles/nrnversion_h] Error 1
make[1]: *** [CMakeFiles/Makefile2:466: src/nrniv/CMakeFiles/nrnversion_h.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

[alexsavulescu]

 cd D:/a/nrn/nrn/build/src/nrniv && C:/msys64/mingw64/bin/cmake.exe -E env PROJECT_VERSION=8.0 C:\msys64\usr\bin\bash.exe D:/a/nrn/nrn/git2nrnversion_h.sh D:/a/nrn/nrn
The system cannot find the file specified

[nrnhines]

2022-01-19T01:14:31.7843905Z The system cannot find the file specified
2022-01-19T01:14:31.7955241Z make[2]: *** [src/nrniv/CMakeFiles/nrnversion_h.dir/build.make:70: src/nrniv/CMakeFiles/nrnversion_h] Error 1
2022-01-19T01:14:31.7977241Z make[1]: *** [CMakeFiles/Makefile2:466: src/nrniv/CMakeFiles/nrnversion_h.dir/all] Error 2

Definitely a puzzle. The build/src/nrniv/CMakeFiles/nrnversion_h.dir folder exists on my last build in my Windows virtualbox guest but CMake seems to have a different build strategy on Linux and that folder does not exist in my linux builds.

[olupton]

In the live-debug session then

# cd D:/a/nrn/nrn/build/src/nrniv && C:/msys64/mingw64/bin/cmake.exe -E env PROJECT_VERSION=8.0 'C:\msys64\usr\bin\bash.exe' D:/a/nrn/nrn/git2nrnversion_h.sh

works and

# cd D:/a/nrn/nrn/build/src/nrniv && C:/msys64/mingw64/bin/cmake.exe -E env PROJECT_VERSION=8.0 C:\msys64\usr\bin\bash.exe D:/a/nrn/nrn/git2nrnversion_h.sh
The system cannot find the file specified

doesn't (note quotes around the path to bash.exe).

Not sure what this means.

[alexsavulescu]

So the issue is with the bash path. If I change C:\msys64\usr\bin\bash.exe toC:/msys64/usr/bin/bash.exe

runneradmin@fv-az108-760 MINGW64 /d/a/nrn/nrn/build/src/nrniv
# cd D:/a/nrn/nrn/build/src/nrniv && C:/msys64/mingw64/bin/cmake.exe -E env PROJECT_VERSION=8.0 C:/msys64/usr/bin/bash.exe D:/a/nrn/nrn/git2nrnversion_h.sh D:/a/nrn/nrn
#define GIT_DATE "2022-01-19"
#define GIT_BRANCH "HEAD"
#define GIT_CHANGESET "5913d31b+"
#define GIT_DESCRIBE "8.0a-726-g5913d31b+"

[olupton]

I don't see what's changed, but maybe if this path is being passed to cmake -E env then https://cmake.org/cmake/help/v3.15/command/file.html?highlight=path#to-cmake-path would be appropriate? In the live-debug session I see

-- ENV{SHELL}=C:\msys64\usr\bin\bash.exe
-- TO_NATIVE_PATH=C:\msys64\usr\bin\bash.exe
-- TO_CMAKE_PATH=C:/msys64/usr/bin/bash.exe

[alexsavulescu]

From

add_custom_target(
  nrnversion_h
  COMMAND ${CMAKE_COMMAND} -E env PROJECT_VERSION=${PROJECT_VERSION} $ENV{SHELL} ${PROJECT_SOURCE_DIR}/git2nrnversion_h.sh ${PROJECT_SOURCE_DIR} > nrnversion.h.tmp
  COMMAND ${CMAKE_COMMAND} -E copy_if_different nrnversion.h.tmp ${NRN_NRNOC_SRC_DIR}/nrnversion.h
  DEPENDS ${PROJECT_SOURCE_DIR}/git2nrnversion_h.sh)

$ENV{SHELL} now expands to C:\msys64\usr\bin\bash.exe instead of C:/msys64/usr/bin/bash.exe