Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrnversion_h: Use bash instead of $ENV{SHELL} #1591

Merged
merged 1 commit into from
Jan 19, 2022
Merged

nrnversion_h: Use bash instead of $ENV{SHELL} #1591

merged 1 commit into from
Jan 19, 2022

Conversation

alexsavulescu
Copy link
Member

* use `bash` since we launch a bash script
* fixes #1590
@codecov-commenter
Copy link

Codecov Report

Merging #1591 (f06c3d3) into master (0050209) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1591      +/-   ##
==========================================
- Coverage   45.19%   45.15%   -0.04%     
==========================================
  Files         551      551              
  Lines      111216   111216              
==========================================
- Hits        50261    50217      -44     
- Misses      60955    60999      +44     
Impacted Files Coverage Δ
src/nrnmpi/bbsmpipack.cpp 82.56% <0.00%> (-10.77%) ⬇️
src/parallel/bbsclimpi.cpp 50.00% <0.00%> (-8.14%) ⬇️
src/parallel/bbssrvmpi.cpp 42.16% <0.00%> (-6.03%) ⬇️
src/parallel/bbs.cpp 74.26% <0.00%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0050209...f06c3d3. Read the comment docs.

@alexsavulescu alexsavulescu merged commit 0faf300 into master Jan 19, 2022
@alexsavulescu alexsavulescu deleted the fixwin branch January 19, 2022 13:13
alexsavulescu added a commit that referenced this pull request Jan 28, 2022
* use `bash` since we launch a bash script
* fixes #1590
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CI builds are broken - $ENV{SHELL} path expands Win-style
3 participants