Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.10 bugfixes & CI updates #1610

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Python 3.10 bugfixes & CI updates #1610

merged 4 commits into from
Feb 1, 2022

Conversation

alexsavulescu
Copy link
Member

@alexsavulescu alexsavulescu commented Feb 1, 2022 •
edited
Loading

@alexsavulescu alexsavulescu linked an issue Feb 1, 2022 that may be closed by this pull request
Windows Python3.10 fails to parse version from pylib #1613
Closed
@alexsavulescu alexsavulescu marked this pull request as draft February 1, 2022 14:56
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022 •
edited
Loading

Codecov Report

Merging #1610 (1144aca) into master (db37a42) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 1144aca differs from pull request most recent head 2b4f3d6. Consider uploading reports for the commit 2b4f3d6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1610      +/-   ##
==========================================
+ Coverage   45.14%   45.19%   +0.04%     
==========================================
  Files         551      551              
  Lines      111190   111189       -1     
==========================================
+ Hits        50198    50250      +52     
+ Misses      60992    60939      -53
Impacted Files Coverage Δ
src/nrniv/nrnpy.cpp 66.31% <ø> (+5.73%) ⬆️
share/lib/python/neuron/rxd/rxdmath.py 56.26% <0.00%> (-0.22%) ⬇️
share/lib/python/neuron/gui2/plotshape.py 0.00% <0.00%> (ø)
...hare/lib/python/neuron/rxd/geometry3d/surface_a.py 100.00% <0.00%> (ø)
.../lib/python/neuron/rxd/geometry3d/FullJoinMorph.py 96.73% <0.00%> (+0.02%) ⬆️
share/lib/python/neuron/rxd/rxd.py 83.74% <0.00%> (+0.04%) ⬆️
share/lib/python/neuron/__init__.py 41.19% <0.00%> (+0.07%) ⬆️
share/lib/python/neuron/rxd/species.py 78.67% <0.00%> (+0.18%) ⬆️
share/lib/python/neuron/gui.py 68.42% <0.00%> (+0.56%) ⬆️
share/lib/python/neuron/rxd/plugins.py 28.45% <0.00%> (+0.58%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db37a42...2b4f3d6. Read the comment docs.

@alexsavulescu
docs CI: stick to python 3.8
4c5c21b 
proper windows pyver parsing
@alexsavulescu alexsavulescu changed the title Bump GitHub Action CIs to Python 3.10 Python 3.10 support & CI updates Feb 1, 2022
@alexsavulescu alexsavulescu changed the title Python 3.10 support & CI updates Python 3.10 bugfixes & CI updates Feb 1, 2022
@alexsavulescu alexsavulescu marked this pull request as ready for review February 1, 2022 15:30
olupton
olupton approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@olupton olupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, a couple of minor suggestions.

.github/workflows/docs.yml Show resolved Hide resolved
src/nrniv/nrnpy.cpp Outdated Show resolved Hide resolved
src/nrniv/nrnpy.cpp Show resolved Hide resolved
@alexsavulescu alexsavulescu merged commit 4293b61 into master Feb 1, 2022
@alexsavulescu alexsavulescu deleted the py310ci branch February 1, 2022 17:21
alexsavulescu added a commit that referenced this pull request Feb 1, 2022
@alexsavulescu @olupton
Python 3.10 bugfixes & CI updates (#1610)
2ff909d 
* bump GitHub Action CIs to Python 3.10
* stick to Python 3.8 for docs ci (c.f. docs: executing jupyter notebooks with py3.10 fails #1612 )
* Windows: fix pyver parsing (fixes Windows Python3.10 fails to parse version from pylib #1613 )

Co-authored-by: Olli Lupton <[email protected]>
@alexsavulescu alexsavulescu mentioned this pull request Feb 2, 2022
Merged
alexsavulescu added a commit that referenced this pull request Feb 2, 2022
@alexsavulescu @olupton
Python 3.10 bugfixes & CI updates (#1610)
9f1cb0b 
* bump GitHub Action CIs to Python 3.10
* stick to Python 3.8 for docs ci (c.f. docs: executing jupyter notebooks with py3.10 fails #1612 )
* Windows: fix pyver parsing (fixes Windows Python3.10 fails to parse version from pylib #1613 )

Co-authored-by: Olli Lupton <[email protected]>
@alexsavulescu alexsavulescu mentioned this pull request Feb 11, 2022
Closed
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olupton olupton olupton approved these changes

@nrnhines nrnhines Awaiting requested review from nrnhines

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Python3.10 fails to parse version from pylib
3 participants
@alexsavulescu @codecov-commenter @olupton