Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 8.0.2 #1614

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Release 8.0.2 #1614

merged 3 commits into from
Feb 2, 2022

Conversation

alexsavulescu
Copy link
Member

@alexsavulescu alexsavulescu commented Feb 1, 2022

After release 8.0.1 we now know:

  • Our master (and release) CIs should've been adjusted to Python 3.10
  • after which, a couple of issues were unfolded (RXD and Windows); we would've probably stumbled upon them anyways with 8.1

Changelog

8.0.2

Release Date : 02-02-2022

Bug Fixes

Python 3.10 bugfixes for RXD and Windows, more details in GitHub PR #1614

Commits going into 8.0.2

via

git log --pretty=format:"%h : %s" 8.0.1..8.0.2-cherries

2ff909d : Python 3.10 bugfixes & CI updates (#1610)
ec8c7a3 : NEURON 8.0.x RXD node: backward compatible Callable

alexsavulescu and others added 2 commits February 1, 2022 16:29
* bump GitHub Action CIs to Python 3.10
* stick to Python 3.8 for docs ci (c.f. docs: executing jupyter notebooks with py3.10 fails #1612 )
* Windows: fix pyver parsing (fixes Windows Python3.10 fails to parse version from pylib #1613 )

Co-authored-by: Olli Lupton <[email protected]>
@olupton
Copy link
Collaborator

olupton commented Feb 1, 2022

@alexsavulescu
Copy link
Member Author

alexsavulescu commented Feb 1, 2022

https://github.com/neuronsimulator/nrn-build-ci/actions/runs/1779878443

We could've easily spotted one of the two aforementioned issues if we had launched this before the release. Thinking about it, we should have a GH issue template for new releases where we track down the required actions items pre and post release.

@olupton olupton linked an issue Feb 2, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #1614 (f42894a) into release/8.0 (7774c0d) will increase coverage by 0.18%.
The diff coverage is 60.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/8.0    #1614      +/-   ##
===============================================
+ Coverage        32.17%   32.36%   +0.18%     
===============================================
  Files              572      573       +1     
  Lines           109527   113170    +3643     
===============================================
+ Hits             35241    36625    +1384     
- Misses           74286    76545    +2259     
Impacted Files Coverage Δ
src/nrniv/nrnpy.cpp 64.94% <ø> (+5.33%) ⬆️
share/lib/python/neuron/rxd/node.py 77.20% <60.00%> (-0.31%) ⬇️
src/ivoc/mymath.h 40.00% <0.00%> (-6.16%) ⬇️
src/mesch/machine.c 50.00% <0.00%> (-2.64%) ⬇️
src/nrnoc/nrntimeout.c 52.00% <0.00%> (-2.17%) ⬇️
src/modlunit/list.c 60.49% <0.00%> (-2.09%) ⬇️
src/oc/hoc_init.c 84.88% <0.00%> (-1.54%) ⬇️
src/oc/list.c 53.38% <0.00%> (-1.48%) ⬇️
src/oc/ftime.c 61.11% <0.00%> (-1.39%) ⬇️
src/nrniv/vrecord.cpp 38.66% <0.00%> (-1.26%) ⬇️
... and 307 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7774c0d...f42894a. Read the comment docs.

@olupton
Copy link
Collaborator

olupton commented Feb 2, 2022

https://github.com/neuronsimulator/nrn-build-ci/actions/runs/1784322918 one more time.

@alexsavulescu alexsavulescu merged commit f0ca745 into release/8.0 Feb 2, 2022
@alexsavulescu alexsavulescu deleted the 8.0.2-cherries branch February 2, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEURON 8.0.2 Release
4 participants