Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.10 #992

Merged
merged 62 commits into from
Aug 16, 2024
Merged

0.2.10 #992

merged 62 commits into from
Aug 16, 2024

Conversation

DominiqueMakowski
Copy link
Member

@DominiqueMakowski DominiqueMakowski commented May 21, 2024

Roadmap

RSP

  • Add rsp_segment() (similar to ppg_segment())
  • Add the cycle overlay plots to RSP
  • Streamline rsp_plot() (same as ppg_plot())

PPG

  • Detect PPG diastolic peaks? (between each peak and the next trough)
  • Add PPG amplitude calculation (reduction can be indicative of vasoconstriction in stress, cold)
  • Document peak-extraction methods (PPG)
  • add more PPG detectors (@peterhcharlton)
  • hrv_rsa(): Add method argument to compute only one RSA signal. Do something with warning that will be thrown when using bio_process() on signals < 32 sec where it will complain that the signal is too short to compute RSA with one of these methods.

Misc

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 12, 2024
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Aug 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.10738% with 125 lines in your changes missing coverage. Please review.

Project coverage is 56.36%. Comparing base (3d004b4) to head (ee87db7).
Report is 103 commits behind head on master.

Files Patch % Lines
neurokit2/ppg/ppg_findpeaks.py 1.60% 123 Missing ⚠️
neurokit2/ecg/ecg_findpeaks.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
+ Coverage   54.86%   56.36%   +1.50%     
==========================================
  Files         303      305       +2     
  Lines       14255    14576     +321     
==========================================
+ Hits         7821     8216     +395     
+ Misses       6434     6360      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

peterhcharlton and others added 3 commits August 6, 2024 09:20
Brief update to description of the 'neurokit' ecg_peaks method, to include the publication validating this algorithm.
[Docs] Add info about NK ECG peak detection method
[Feature] Codebook Generation from Documentation
@DominiqueMakowski
Copy link
Member Author

I'm going to merge this soon

@DominiqueMakowski DominiqueMakowski merged commit 45c9ad9 into master Aug 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants