Initial syslog support in XRDP #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexarian
added a commit
to Nexarian/xrdp
that referenced
this pull request
Feb 14, 2022
# This is the 1st commit message: Resolution switching without reconnecting. - Based on https://github.com/jsorg71/xrdp/tree/dynamic_monitor - Tested with xorgxrdp - Tested with vnc - Only works with single monitor. - Update documentation to clarify the difference between MSTSC and Microsoft Remote Desktop. - Does not include compatibility with /gfx at this time, which is still in testing. - Updates to include ms-rdpedisp.h header for the 2.2.2 specification of the protocol. - Adds new dynamic_monitor_layout struct that shares the number of monitors with xrdp_client_info.h - Modification to the original resize setup that works with /gfx. Depends on neutrinolabs/xorgxrdp#183 # This is the commit message #2: Merging with egfx. # This is the commit message #3: Updating with reset graphics that stabilizes resize. # This is the commit message #4: Egfx resizing is stable now. # This is the commit message #5: Refactor resizing such that it uses a processing queue. # This is the commit message #6: Stability fix for the mac os client. # This is the commit message #7: Fixing bug where the resolution may be wrong on startup. Add an "invalid" marker to the queue, and if the marker is present, ignore the dynamic resolution update. # This is the commit message #8: Updating monitor processing in preparation for merging with xrdp_sec. # This is the commit message #9: Refactored monitor processing to be shared. Both xrdp_sec and the dynamic monitor channel both used very similar monitor processing routines. They are different specs, but almost identical in the way they work. Refactor the code to be common so that the behavior is consistent across the two. # This is the commit message neutrinolabs#10: Adding nvenc encoder compatibility. # This is the commit message neutrinolabs#11: Fixing build break and remerging with dynamic monitor refactor. # This is the commit message neutrinolabs#12: Fixing more breaks. # This is the commit message neutrinolabs#13: Fixing more bad merges. # This is the commit message neutrinolabs#14: Merging in xorgxrdp_helper hack. # This is the commit message neutrinolabs#15: Fixing npe for logging. # This is the commit message neutrinolabs#16: Merging with helper fixes. # This is the commit message neutrinolabs#17: Misc stability fixes. # This is the commit message neutrinolabs#18: More merge fixes. # This is the commit message neutrinolabs#19: Improving resize stability. # This is the commit message neutrinolabs#20: Refactor resizing - State machine. - Mechanisms to make sure the key frame is always sent on resize. - Stability enhancements. # This is the commit message neutrinolabs#21: Fixing typo. # This is the commit message neutrinolabs#22: Fix for when H264 is disabled. # This is the commit message neutrinolabs#23: Stability enhancement. Prevent infinite loop with Microsoft Remote Desktop MacOS Client. # This is the commit message neutrinolabs#24: Removing log that causes problems.
matt335672
pushed a commit
to matt335672/xrdp
that referenced
this pull request
Feb 25, 2022
snprintf requires malloc before copying strings. I didn't do enough test the case when socket names were not given via environment variable.
matt335672
pushed a commit
to matt335672/xrdp
that referenced
this pull request
Feb 25, 2022
Fix segfault when socket names not given via env neutrinolabs#19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log.c and log.h are now common for all processes. Logs are sent to debug screen and to syslog. The API for logging is changed.