-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set PCSCLITE_CSOCK_NAME env var #963
base: devel
Are you sure you want to change the base?
Conversation
Check for PCSC sockets should be added to |
Yes, thanks |
OK, trying to test this but having some problems. As I stated before, but restating:
Any help on how to solve or further debug is appreciated. |
early version did that |
Here's the output of foreground xrdp --n
|
Here's the output of foreground xrdp-sesman -n
|
/var/log/xrdp.log
|
/var/log/xrdp-sesman.log
|
Anyone? Any help on how to solve or further debug is appreciated. |
maybe this is a problem |
Not a problem, its irrelevant.
Any other ideas? |
Back to the stock release, with replacement pcsclite. Any help on how to debug? How can I find out if card info is reaching xrdp/chanserv? |
@@ -1954,10 +1961,10 @@ scard_send_Transmit(IRP *irp, char *context, int context_bytes, | |||
val = send_bytes > 0 ? 0x00020008 : 0; | |||
out_uint32_le(s, val); /* map3 */ | |||
|
|||
val = recv_ior->cbPciLength > 0 ? 0x0002000c : 0; | |||
val = recv_ior_is_null ? 0 : 0x00020008; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this constant come from?
g_snprintf(g_pcsclite_ipc_dir, 255, "%s/.pcsc%d", home, disp); | ||
|
||
if (g_directory_exist(g_pcsclite_ipc_dir)) | ||
csock_name = g_getenv("XRDP_PCSCLITE_CSOCK_NAME"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see this environment variable is defined anywhere. Defined constant in env.c
is PCSCLITE_CSOCK_NAME
. No XRDP_
prefix.
Coding style changes should be done in the separated commit. Excluding in the case when coding style changes are small enough. |
Hi, Made it working on RHEL7.9 with a gemalto MD840 and omnikey reader. How can I contribute to this ? Knowing that my skills in dev are low... Probably need help on that side. |
No description provided.