Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(run-versioned-tests.sh): added ability to run versioned tests and skip collecting coverage by passing in C8 env var to the job. #1621

Merged
merged 2 commits into from
May 8, 2023

Conversation

bizob2828
Copy link
Member

Proposed Release Notes

  • refactor (run-versioned-tests.sh): added ability to run versioned tests and skip collecting coverage by passing in C8 env var to the job.
    • Updates .c8rc.json to remove redundant html reporter as lcov does both lcov and html.

Links

Details

I did this work in #1617 but that is not merging to main right away. I wanted to get these changes in.

@jmartin4563 jmartin4563 changed the title refactor (run-versioned-tests.sh): added ability to run versioned tests and skip collecting coverage by passing in C8 env var to the job. refactor(run-versioned-tests.sh): added ability to run versioned tests and skip collecting coverage by passing in C8 env var to the job. May 4, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #1621 (8668c58) into main (f2dd6d3) will not change coverage.
The diff coverage is n/a.

❗ Current head 8668c58 differs from pull request most recent head 83e95e3. Consider uploading reports for the commit 83e95e3 to get more accurate results

@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         200      200           
  Lines       39053    39053           
  Branches       24       24           
=======================================
  Hits        37644    37644           
  Misses       1409     1409           
Flag Coverage Δ
esm-unit-tests-14.x 47.80% <ø> (ø)
esm-unit-tests-16.x 92.11% <ø> (ø)
esm-unit-tests-18.x 92.11% <ø> (ø)
integration-tests-14.x 78.96% <ø> (ø)
integration-tests-16.x 79.05% <ø> (+0.01%) ⬆️
integration-tests-18.x 79.05% <ø> (ø)
unit-tests-14.x 90.48% <ø> (ø)
unit-tests-16.x 90.54% <ø> (ø)
unit-tests-18.x 90.52% <ø> (ø)
versioned-tests-14.x 75.27% <ø> (+0.01%) ⬆️
versioned-tests-16.x 76.56% <ø> (ø)
versioned-tests-18.x 76.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmartin4563 jmartin4563 self-assigned this May 5, 2023
Copy link
Contributor

@jmartin4563 jmartin4563 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thought about the env var name

.github/workflows/versioned-coverage.yml Outdated Show resolved Hide resolved
.c8rc.json Show resolved Hide resolved
…s and skip collecting coverage by passing in `C8` env var to the job.

 * Updates `.c8rc.json` to remove redundant html reporter as lcov does both lcov and html.
@bizob2828 bizob2828 merged commit b79255d into newrelic:main May 8, 2023
@github-actions github-actions bot mentioned this pull request May 15, 2023
@bizob2828 bizob2828 added the dev:automation Indicates CI automation label May 15, 2023
@bizob2828 bizob2828 deleted the skip-c8 branch August 28, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:automation Indicates CI automation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants