Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v10.1.1 #1642

Merged
merged 6 commits into from
May 15, 2023
Merged

chore: release v10.1.1 #1642

merged 6 commits into from
May 15, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 15, 2023

v10.1.1 (2023-05-15)

Bug Fixes

  • updated prisma instrumentation to properly parse database connection strings that work across all versions of prisma (#1634) (b2101fd)

Code Refactoring

  • run-versioned-tests.sh: added ability to run versioned tests and skip collecting coverage by passing in SKIP_C8 env var to the job. (#1621) (0ba9dcb)

Documentation

  • update Contribution Guide with Conventional Commit info (#1635) (f1a00e5)

Miscellaneous Chores

  • pin testdobule to 3.17.2 as 3.18.0 no longer works on node 14 (#1628) (d68bd9f)
  • remove release-please workflow and scripts (#1624) (80f7eb8)

Tests

  • pin prisma to 4.14.0 until we fix instrumentation (#1631) (a60659d)
  • scripts: fix failing changelog unit test (#1626) (08f48b3)
  • config: increase test coverage (#1625) (67f39d8)
  • config: revert changes to lib/config/index.js (#1630) (fea1068)

Continuous Integration

  • changed versioned tests script to use SKIP_C8 (#1621) (83e95e3)
  • add --use-new-release functionality (#1633) (d97b421)
  • add ability to generate release notes from conventional commits (#1623) (880a88b)
  • create-docs-pr: Set username/email to machine user by default (#1627) (3870a1f)
  • fix issue with missing type in the prep-release (#1638) (9a906e8)
  • update prep-release to fetch entire history of caller repo (#1641) (428174a)
  • update to conditionally add CLI flag to prep-release (#1640) (b167c93)

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1642 (a1c5aba) into main (b167c93) will increase coverage by 2.88%.
The diff coverage is n/a.

❗ Current head a1c5aba differs from pull request most recent head 22fe376. Consider uploading reports for the commit 22fe376 to get more accurate results

@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
+ Coverage   93.67%   96.55%   +2.88%     
==========================================
  Files         181      200      +19     
  Lines       37154    39064    +1910     
  Branches       24       24              
==========================================
+ Hits        34803    37720    +2917     
+ Misses       2351     1344    -1007     
Flag Coverage Δ
esm-unit-tests-14.x 47.80% <ø> (ø)
esm-unit-tests-16.x 92.11% <ø> (ø)
esm-unit-tests-18.x 92.11% <ø> (ø)
integration-tests-14.x 78.97% <ø> (ø)
integration-tests-16.x 79.07% <ø> (ø)
integration-tests-18.x 79.07% <ø> (ø)
unit-tests-14.x 90.66% <ø> (ø)
unit-tests-16.x 90.72% <ø> (ø)
unit-tests-18.x 90.70% <ø> (ø)
versioned-tests-14.x 75.29% <ø> (?)
versioned-tests-16.x 76.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 44 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmartin4563 jmartin4563 marked this pull request as ready for review May 15, 2023 16:43
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can iterate on this changelog, it's accurate but a lot mean nothing to our users.

@jmartin4563
Copy link
Contributor

We can iterate on this changelog, it's accurate but a lot mean nothing to our users.

If we decide that there are whole sections we would like to ignore, then we can update https://github.com/newrelic/node-newrelic/blob/main/bin/conventional-changelog.js#L18 to include a hidden: true. Not saying to do that now, but just for future us if we come back to this PR with questions.

@jmartin4563 jmartin4563 merged commit b924534 into main May 15, 2023
@jmartin4563 jmartin4563 deleted the release/v10.1.1 branch May 15, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants