-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add ability to generate release notes from conventional commits #1623
ci: add ability to generate release notes from conventional commits #1623
Conversation
Created the ConventionalChangelog class, which has methods for parsing conventional commits from the git log, as well as methods for generating JSON and Markdown changelogs. JSON changelogs will be used by the docs-website PR script to generate the front-matter for Agent Version Metadata service. Markdown changelogs are for our own documentation and for customers to read
Codecov Report
@@ Coverage Diff @@
## main #1623 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 200 200
Lines 39053 39053
Branches 24 24
=======================================
Hits 37644 37644
Misses 1409 1409
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
We've decided as a team to drop release-please in lieu of #1623, this PR just removes the remnants of release-please configuration/automation.
|
||
{{#if noteGroups}} | ||
{{#each noteGroups}} | ||
#### ⚠ {{title}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that triangle-and-! character in the space intentionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Looks like it might be for breaking changes.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for breaking changes. I'm not sure why they do this, but currently the only supported note
type is a breaking change, so noteGroups
only has one possible group, which is also breaking change (see https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-commits-parser/test/parser.spec.js for examples of what comes out of the parser)
Proposed Release Notes
Created the
ConventionalChangelog
class, which has methods for parsing conventional commits from the git log, as well as methods for generating JSON and Markdown changelogs. JSON changelogs will be used by the docs-website PR script to generate the front-matter for Agent Version Metadata service. Markdown changelogs are for our own documentation and for customers to read.Links
Details
The expectation is that this class will be used in NR-96236, where we'll conditionally (since the external repos use the same scripting) update
prepare-release.js
to use this class, andcreate-docs-pr.js
to consumechangelog.json
for the front-matter fields.To manually test, use the following script and observe the updates to NEWS.md and
changelog.json