fix: Set username/email to machine user by default #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrickard <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1627 +/- ##
==========================================
+ Coverage 96.52% 96.55% +0.03%
==========================================
Files 200 200
Lines 39039 39043 +4
Branches 24 24
==========================================
+ Hits 37681 37699 +18
+ Misses 1358 1344 -14
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bizob2828
reviewed
May 9, 2023
bin/create-docs-pr.js
Outdated
| @@ -281,7 +284,7 @@ async function createPR(username, version, branch, dryRun, repoOwner) { | |||
| const github = new Github(repoOwner, 'docs-website') | |||
| const title = `Node.js Agent ${version} Release Notes` | |||
| const prOptions = { | |||
| head: `${username}:${branch}`, | |||
| head: `${branch}`, | |||
There was a problem hiding this comment.
this won't work when we run locally but it seems like repoOwner and username were redundant in this case right?
There was a problem hiding this comment.
I've updated this to run locally, though it's using repoOwner for the fork instead of username.
…e main repo. Otherwise, if run locally, it should be to a fork. Signed-off-by: mrickard <[email protected]>
bizob2828
requested changes
May 10, 2023
…eady exists locally. Signed-off-by: mrickard <[email protected]>
|
@bizob2828 I've updated so that the docs repo won't be cloned if it already exists locally on repo-path. Mind taking another look? |
bizob2828
approved these changes
May 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Changed post-release create-docs-pr job to use the machine user username/email, and removed the fork syntax from the docs PR.
Links
NR-96240
Details