-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly align the settings label #2210
Conversation
Signed-off-by: Raimund Schlüßler <[email protected]>
#app-settings-header .settings-button { | ||
padding-left: 50px; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue the opposite, should be fixed in files, no?
What is the AppNavigationItem using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not Files, this is Tasks and Calendar and literally every other app which uses AppNavigationItem. These 6 px here:
https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/AppNavigationItem/AppNavigationItem.vue#L520
add to the 44 px icon width, which make it 50 px in total.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added in this commit 5e7e395
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This style is coming from server, I didn't want to mess with it, especially not in this tiny PR.
I overwrote this style in the Tasks app (see here https://github.com/nextcloud/tasks/blob/005cd27fda7ce5f53d65c469bb254458fe3abe0d/src/views/AppNavigation.vue#L456-L458) because this misalignment annoyed me 🙈 This PR here upstreams this fix. Checkout the Calendar or Contacts app, there it is off. |
Superseded by #2211. |
After:
Before:
Closes #2138