Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use material design icon for settings icon #2211

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Use material design icon for settings icon #2211

merged 1 commit into from
Sep 7, 2021

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Sep 6, 2021 •
edited
Loading

This PR replaces the current settings icon with the material design equivalent and also fixes the settings label alignment to the AppNavigationItem component. Supersedes #2210, closes #2138 and fixes the second part of #2199.

After:
Screenshot 2021-09-06 at 22-30-42 Tasks - Nextcloud

Before:
Screenshot 2021-09-06 at 21-24-43 Tasks - Nextcloud

szaimen
szaimen approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add opacity: 1 !important; so that the stile fits the trashbin?

@raimund-schluessler
Copy link
Contributor Author

can you add opacity: 1 !important; so that the stile fits the trashbin?

This is a server style which I just copied. I guess the lower opacity is intendend.

@szaimen
Copy link
Contributor

szaimen commented Sep 6, 2021

I guess the lower opacity is intendend.

jep, but only for the files app (because the other labels have the same opacity there).

@raimund-schluessler
Copy link
Contributor Author

I guess the lower opacity is intendend.

jep, but only for the files app (because the other labels have the same opacity there).

So it was wrong all the time in every other app, because the Files app messed with the opacity? 😄
I guess we can fix it then.

@raimund-schluessler
Copy link
Contributor Author

can you add opacity: 1 !important; so that the stile fits the trashbin?

Fixed. I updated the screenshot in the first post.

@raimund-schluessler raimund-schluessler mentioned this pull request Sep 6, 2021
Closed
@raimund-schluessler raimund-schluessler added this to the 4.1.1 milestone Sep 6, 2021
@szaimen
Copy link
Contributor

szaimen commented Sep 7, 2021 •
edited
Loading

can you add opacity: 1 !important; so that the stile fits the trashbin?

Fixed. I updated the screenshot in the first post.

@raimund-schluessler How did you fix it? I don't see opacity: 1 !important; in the code...

@raimund-schluessler
Copy link
Contributor Author

can you add opacity: 1 !important; so that the stile fits the trashbin?

Fixed. I updated the screenshot in the first post.

How did you fix it? I don't see opacity: 1 !important; in the code...

opacity: 0.8 came from the server style, which does not apply anymore because the selectors are different now. So no need to overwrite it.

@szaimen szaimen merged commit 543b06c into master Sep 7, 2021
@szaimen szaimen deleted the fix/settings-icon branch September 7, 2021 08:24
@szaimen
Copy link
Contributor

szaimen commented Sep 7, 2021

/backport to stable4

@szaimen szaimen modified the milestones: 4.1.1, 5.0.0 Sep 7, 2021
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 7, 2021
Merged
@raimund-schluessler raimund-schluessler mentioned this pull request Sep 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen szaimen approved these changes

@korelstar korelstar Awaiting requested review from korelstar

@GretaD GretaD Awaiting requested review from GretaD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Settings label not aligned to app-navigation-entry
3 participants
@raimund-schluessler @szaimen @skjnldsv