Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(a11y): added aria-label that matches title attr on icon #5078

Merged

Conversation

emoral435
Copy link
Contributor

@emoral435 emoral435 commented Jan 16, 2024

☑️ For nextcloud/server#42855

Once the nextcloud/vue8.5.0 releases a,d the server repository gets the new library update, then the servers issue will be properly fixed!

Summary

Adds an aria label to all sections that use NcSettings Section
image
Example ^ This now has an aria label. Since the icon has no text, it needs a label AND a title for accessibility

🏁 Checklist

  • ⛑️ Tests are included or are not applicable - not applicable
  • 📘 Component documentation has been extended, updated or is not applicable - not applicable

@emoral435 emoral435 added enhancement New feature or request 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jan 16, 2024
@emoral435 emoral435 added this to the 8.5.0 milestone Jan 16, 2024
@emoral435 emoral435 self-assigned this Jan 16, 2024
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raimund-schluessler raimund-schluessler merged commit 07862b4 into master Jan 16, 2024
15 checks passed
@raimund-schluessler raimund-schluessler deleted the enh/a11y/42855/add-aria-label-to-help-circle branch January 16, 2024 22:07
@Pytal Pytal mentioned this pull request Jan 23, 2024
@nextcloud-libraries nextcloud-libraries deleted a comment from backportbot bot Feb 2, 2024
@nextcloud-libraries nextcloud-libraries deleted a comment from backportbot bot Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities backport-request enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants