Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV]: Add extra aria labels to several sections #42855

Closed
emoral435 opened this issue Jan 16, 2024 · 5 comments
Closed

[BITV]: Add extra aria labels to several sections #42855

emoral435 opened this issue Jan 16, 2024 · 5 comments
Assignees
@emoral435
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement
Milestone
Nextcloud 29

Comments

@emoral435
Copy link
Contributor

From #42744, [these] are the places that need aria-labels on. This wil take several different PR's to fix, as some fixes will require libraries being changed, and nextcloud/server being changed as well!

Image
@emoral435 emoral435 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Jan 16, 2024
@emoral435 emoral435 added this to the Nextcloud 29 milestone Jan 16, 2024
@emoral435 emoral435 self-assigned this Jan 16, 2024
@emoral435 emoral435 mentioned this issue Jan 16, 2024
Merged
2 tasks
@emoral435 emoral435 changed the title Add extra aria labels to several sections [BITV]: Add extra aria labels to several sections Jan 16, 2024
@emoral435 emoral435 added pending dependency update 4. to release Ready to be released and/or waiting for tests to finish and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 17, 2024
@emoral435
Copy link
Contributor Author

Now with the library merged - should be done 👍 will close once it gets the a11y28check !

@szaimen szaimen closed this as completed Feb 2, 2024
@szaimen
Copy link
Contributor

szaimen commented Feb 2, 2024

Not sure if this implementation is correct in settings/user/sharing:
image
also here:
image
and all the other sides...

@szaimen szaimen reopened this Feb 2, 2024
@emoral435
Copy link
Contributor Author

My bad - once #43064 gets merged, good to be checked 👍

@szaimen
Copy link
Contributor

szaimen commented Feb 5, 2024

I checked all mentnioned pages and found two missing places:

image

image

@emoral435 emoral435 mentioned this issue Feb 5, 2024
Merged
5 tasks
@JuliaKirschenheuter
Copy link
Contributor

closing as done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emoral435 emoral435

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement
Projects
None yet
Milestone
Nextcloud 29
Development

No branches or pull requests
3 participants
@JuliaKirschenheuter @szaimen @emoral435