Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set VFS PinState to Excluded for ignored files. #5853

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Set VFS PinState to Excluded for ignored files. #5853

merged 3 commits into from
Jul 20, 2023

Commits on Jul 20, 2023

  1. Set VFS PinState to Excluded for ignored files. 

    Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Co-authored-by: Matthieu Gallien <[email protected]>
Signed-off-by: Dries Mys <[email protected]>
    @m7913d @mgallien
    m7913d and mgallien committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    76376aa View commit details
    Browse the repository at this point in the history

  2. Remove warning when querying pin state on non-placeholder file 

    F.ex. Folder::slotWatchedPathChanged calls this function on non-
placeholder files to check if the ignored file is already assigned an
Excluded pin state. Note that it is allowed to set the pin state to
Excluded on non-placeholder files.

Signed-off-by: Dries Mys <[email protected]>
    @m7913d @mgallien
    m7913d authored and mgallien committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    e9aa976 View commit details
    Browse the repository at this point in the history

  3. Small coding improvements 

    Signed-off-by: Dries Mys <[email protected]>
    @m7913d @mgallien
    m7913d authored and mgallien committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    55f27cd View commit details
    Browse the repository at this point in the history