Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the primary color and adjust the width when it's the only option #219

Conversation

nickvergessen
Copy link
Member

Before After
Bildschirmfoto von 2020-07-10 14-15-12 Bildschirmfoto von 2020-07-10 14-14-52

Fix #68

cc @Becker-Asano

@nickvergessen nickvergessen merged commit 39f298c into master Jul 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/68/use-primary-color-for-button-and-adjust-width-when-only-option branch July 14, 2020 08:45
@zorn-v
Copy link
Member

zorn-v commented Jul 17, 2020

I think change "global" styles in app is not good idea.
Your button will be looks different (and may be buggy) on others version of nextcloud.

@nickvergessen
Copy link
Member Author

What exactly do you mean?

@zorn-v
Copy link
Member

zorn-v commented Jul 20, 2020

You set fixed width for registration button with fixed margin also.
What happen if width of container will modified in next nextcloud versions styles ?
What if will be decided to change login button width etc.

In previous NC versions (prior to 18 AFAIR), container width was 300px AFAIR

@nickvergessen
Copy link
Member Author

This change is only available for the next version which will be only available on nextcloud 20 and later. If that button changes again we will adapt again.

@zorn-v
Copy link
Member

zorn-v commented Jul 21, 2020

Taking into account how "fast" issue like this #210 is resolving, I doubt that it will be fast.
And users may endure ugly button through several NC versions )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app not fully compliant with theming
3 participants