Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete max-width parameter from alternate-login tag #19000

Closed
wants to merge 4 commits into from

Conversation

Becker-Asano
Copy link

@Becker-Asano Becker-Asano commented Jan 19, 2020

This time, I signed the commit. Sorry..

Resubmit of #18998

When using app "https://github.com/pellaeon/registration" the "Registration" button on the start page is off-center. This seems to result from the combination of min-width and max-width for the css-tag #alternate-login, defined here.
Deleted max-width parameter from alternate-login tag
Deleted max-width parameter from alternate-login tag

Signed-off-by: Christian Becker-Asano <[email protected]>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews design Design, UI, UX, etc. labels Jul 2, 2020
@ChristophWurst ChristophWurst added this to the Nextcloud 20 milestone Jul 2, 2020
@MorrisJobke
Copy link
Member

@nextcloud/designers Please review :)

@jancborchardt
Copy link
Member

This was added by @ochorocho via #16832 – could you review? :)

@zorn-v
Copy link
Member

zorn-v commented Jul 7, 2020

Not good idea. I have something like this if remove max-width
изображение

@kesselb
Copy link
Contributor

kesselb commented Jul 7, 2020

Hmm. This should be fixed by https://github.com/pellaeon/registration then? They might have a look at https://github.com/zorn-v/nextcloud-social-login how to do it properly.

@zorn-v
Copy link
Member

zorn-v commented Jul 7, 2020

This was broken here 7e5956a
by setting width: 100%

Related PR #19031

@ochorocho
Copy link
Contributor

I think @zorn-v is right. Removing this is not a good idea.

Copy link
Member

@zorn-v zorn-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some styles of guest page must be rewritten (with cleanup). Maybe with layout change.
Currently one style affect another in unpredictable way, after mixing flexbox with old styles.

@pellaeon
Copy link
Contributor

pellaeon commented Jul 9, 2020

I'm not quite understanding the exact details of this, but this seems to be about the "Register" button issue in pellaeon/registration . This issue was also raised to me by @nickvergessen and it's on our roadmap to be fixed.

@nickvergessen
Copy link
Member

Fixing in the registration app with nextcloud/registration#219
It will trim the length when it's the only option to the width of the login button and otherwise it will be as before.

@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
57 tasks
@MorrisJobke
Copy link
Member

Fixing in the registration app with nextcloud/registration#219
It will trim the length when it's the only option to the width of the login button and otherwise it will be as before.

As there seem to be a fix in another code part I will close this. If this still applies then we can reopen it and check out the issue again.

@MorrisJobke MorrisJobke removed this from the Nextcloud 20 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.