-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete max-width parameter from alternate-login tag #19000
Conversation
When using app "https://github.com/pellaeon/registration" the "Registration" button on the start page is off-center. This seems to result from the combination of min-width and max-width for the css-tag #alternate-login, defined here.
Deleted max-width parameter from alternate-login tag
Deleted max-width parameter from alternate-login tag Signed-off-by: Christian Becker-Asano <[email protected]>
@nextcloud/designers Please review :) |
This was added by @ochorocho via #16832 – could you review? :) |
Hmm. This should be fixed by https://github.com/pellaeon/registration then? They might have a look at https://github.com/zorn-v/nextcloud-social-login how to do it properly. |
I think @zorn-v is right. Removing this is not a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some styles of guest page must be rewritten (with cleanup). Maybe with layout change.
Currently one style affect another in unpredictable way, after mixing flexbox with old styles.
I'm not quite understanding the exact details of this, but this seems to be about the "Register" button issue in pellaeon/registration . This issue was also raised to me by @nickvergessen and it's on our roadmap to be fixed. |
Fixing in the registration app with nextcloud/registration#219 |
As there seem to be a fix in another code part I will close this. If this still applies then we can reopen it and check out the issue again. |
This time, I signed the commit. Sorry..
Resubmit of #18998