Skip to content

Commit

Permalink
Set the filemodel before rending the detailsview
Browse files Browse the repository at this point in the history
fixes #10934

Else it triggers the rendering two times. Resulting is weird state in
for example the comments. Because the comments for OLD_FILEID are
retrieved but then the model is changed to NEW_FILEID. But the old
comments still get in and get parsed.

Signed-off-by: Roeland Jago Douma <[email protected]>
  • Loading branch information
rullzer committed Nov 6, 2018
1 parent 288991a commit 2d153ad
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion apps/files/js/filelist.js
Original file line number Diff line number Diff line change
Expand Up @@ -568,8 +568,8 @@
}

this._currentFileModel = model;
this._detailsView.render();
this._detailsView.setFileInfo(model);
this._detailsView.render();
this._detailsView.$el.scrollTop(0);
},

Expand Down

0 comments on commit 2d153ad

Please sign in to comment.