-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #32723 from MartinBrugnara/master
Expose umask override value as config parameter: localstorage.umask
- Loading branch information
Showing
2 changed files
with
21 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ | |
* @author Jörn Friedrich Dreyer <[email protected]> | ||
* @author Klaas Freitag <[email protected]> | ||
* @author Lukas Reschke <[email protected]> | ||
* @author Martin Brugnara <[email protected]> | ||
* @author Michael Gapczynski <[email protected]> | ||
* @author Morris Jobke <[email protected]> | ||
* @author Robin Appelman <[email protected]> | ||
|
@@ -66,6 +67,8 @@ class Local extends \OC\Files\Storage\Common { | |
|
||
private IMimeTypeDetector $mimeTypeDetector; | ||
|
||
private $defUMask; | ||
|
||
public function __construct($arguments) { | ||
if (!isset($arguments['datadir']) || !is_string($arguments['datadir'])) { | ||
throw new \InvalidArgumentException('No data directory set for local storage'); | ||
|
@@ -84,6 +87,7 @@ public function __construct($arguments) { | |
$this->dataDirLength = strlen($this->realDataDir); | ||
$this->config = \OC::$server->get(IConfig::class); | ||
$this->mimeTypeDetector = \OC::$server->get(IMimeTypeDetector::class); | ||
$this->defUMask = $this->config->getSystemValue('localstorage.umask', 0022); | ||
} | ||
|
||
public function __destruct() { | ||
|
@@ -95,7 +99,7 @@ public function getId() { | |
|
||
public function mkdir($path) { | ||
$sourcePath = $this->getSourcePath($path); | ||
$oldMask = umask(022); | ||
$oldMask = umask($this->defUMask); | ||
$result = @mkdir($sourcePath, 0777, true); | ||
umask($oldMask); | ||
return $result; | ||
|
@@ -273,7 +277,7 @@ public function touch($path, $mtime = null) { | |
if ($this->file_exists($path) and !$this->isUpdatable($path)) { | ||
return false; | ||
} | ||
$oldMask = umask(022); | ||
$oldMask = umask($this->defUMask); | ||
if (!is_null($mtime)) { | ||
$result = @touch($this->getSourcePath($path), $mtime); | ||
} else { | ||
|
@@ -292,7 +296,7 @@ public function file_get_contents($path) { | |
} | ||
|
||
public function file_put_contents($path, $data) { | ||
$oldMask = umask(022); | ||
$oldMask = umask($this->defUMask); | ||
$result = file_put_contents($this->getSourcePath($path), $data); | ||
umask($oldMask); | ||
return $result; | ||
|
@@ -365,15 +369,15 @@ public function copy($path1, $path2) { | |
if ($this->is_dir($path1)) { | ||
return parent::copy($path1, $path2); | ||
} else { | ||
$oldMask = umask(022); | ||
$oldMask = umask($this->defUMask); | ||
$result = copy($this->getSourcePath($path1), $this->getSourcePath($path2)); | ||
umask($oldMask); | ||
return $result; | ||
} | ||
} | ||
|
||
public function fopen($path, $mode) { | ||
$oldMask = umask(022); | ||
$oldMask = umask($this->defUMask); | ||
$result = fopen($this->getSourcePath($path), $mode); | ||
umask($oldMask); | ||
return $result; | ||
|