Expose umask override value as config parameter: localstorage.umask #32723
Conversation
MartinBrugnara
force-pushed
the
master
branch
2 times, most recently
from
4d417b8
to
0daf97c
Compare
|
Hi, please revert the whitespace changes. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Commit 451c06d introduced override for umask value. This is needed to avoid broken env configuration or dirty workers to mess with the permissions when creating new files. Most Nextcloud, that does not integrate with external software would work fine with an hard-coded value (451c06d set it at 022). Advanced install may require more flexibility, as such this commit exposes the "umask override value" as configuration parameter: `localstorage.umask` It defaults to 0022 both in code and in config/config.sample.php . Signed-off-by: Martin Brugnara <[email protected]>
|
@kesselb fixed commit (and .vimrc), updated commit message to reflect 0022 vs 7022 and force pushed. |
|
May I kindly ask help understanding the broken tests? 1. ci/drone/pr: says is failing on About 1, I cannot see which is the step that is actually failing. Again, 13 passed and 1 skipped. Where are the failures? About 2 and 3, it seems to be just a transient error or anyway, nothing related to this PR. Could please someone with auth try to re-issue the test? |
Should be fine to ignore it for now. |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable24 |
|
/backport to stable23 |
|
/backport to stable22 |
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable24 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
|
Will this ever get backported to version 24? I implemented my own fix using |
Commit #451c06d introduced override for umask value.
This is needed to avoid broken env configuration or dirty workers
to mess with the permissions when creating new files.
Most Nextcloud, that does not integrate with external software
would work fine with an hard-coded value (#451c06d set it at 022).
Advanced install may require more flexibility, as such this commit
exposes the "umask override value" as configuration parameter:
localstorage.umaskIt defaults to
0022both in code and in config/config.sample.php .extra: I feel like a better default umask should be
7022, but that value breaks some tests and builds. I propose to postpone this discussion0022vs7022to another issue/pr.