Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App navigation design issues #22219

Closed
juliushaertl opened this issue Aug 12, 2020 · 8 comments · Fixed by #22924
Closed

App navigation design issues #22219

juliushaertl opened this issue Aug 12, 2020 · 8 comments · Fixed by #22924
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc.
Milestone

Comments

@juliushaertl
Copy link
Member

Apps might have a name that is too long to fit the 50px space that is available in the app menu (this is usually an issue with translations):

image

Just adjusting the width to fit doesn't work properly since this would mean that the app icons change position on hover:

Peek 2020-08-12 14-02

I discussed this with @jancborchardt already where he proposed a flex layout where the app names would be a separate row of flex items, however this will also not work properly since then we can not detect the hover on the combined icon+text dom elements anymore.

Maybe someone of @nextcloud/designers has an idea how we could solve this in a sane and elegant way.

@juliushaertl juliushaertl added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 12, 2020
@juliushaertl
Copy link
Member Author

As a sidenote, the background color we had for the label was removed due to the gradient in the header, so we could add this back for plain colors (which is the case with theming) however this will not work with the new dashboard UI (#22143) nor the default Nextcloud blue gradient.

@juliushaertl juliushaertl added the design Design, UI, UX, etc. label Aug 12, 2020
@YouveGotMeowxy
Copy link

How about just not showing the labels as text under the icons, and just show the icons; then hovering the cursor over the icon will display the standard tooltip with the app's name?

@jancborchardt
Copy link
Member

How about just not showing the labels as text under the icons, and just show the icons; then hovering the cursor over the icon will display the standard tooltip with the app's name?

We did this previously, however the issue is that we can only show 1 label at a time that way. The point of showing them all was that people who don’t use Nextcloud all the time know what is what quickly.

@jancborchardt
Copy link
Member

A solution which would not look so good but be reasonable and fix the issue at hand is to add a background to the app title – as before already and as discussed – and just accept that it will look different on the various backgrounds. We could use the primary color for it to look the least out-of-place, and use var(--border-radius-pill) for it to blend nicely?

@jancborchardt
Copy link
Member

Hm … doesn’t look so good:
Peek 2020-08-13 14-58

I discussed this with @jancborchardt already where he proposed a flex layout where the app names would be a separate row of flex items, however this will also not work properly since then we can not detect the hover on the combined icon+text dom elements anymore.

Could we not expand the name of the hovered app, and cut the ones left and right accordingly?

@juliushaertl
Copy link
Member Author

Could we not expand the name of the hovered app, and cut the ones left and right accordingly?

At least I didn't find any sane way to do that.

@STaRDoGG
Copy link

STaRDoGG commented Aug 14, 2020

I didn't look at what framework(s) they're using (update: angular), but what about something like Hotjar does?

capture

@juliushaertl
Copy link
Member Author

@STaRDoGG Let me quote @jancborchardt from earlier here:

We did this previously, however the issue is that we can only show 1 label at a time that way. The point of showing them all was that people who don’t use Nextcloud all the time know what is what quickly.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 9, 2020
jancborchardt added a commit that referenced this issue Sep 17, 2020
jancborchardt added a commit that referenced this issue Sep 17, 2020
MorrisJobke added a commit that referenced this issue Sep 18, 2020
Make sure most app names don’t ellipsize, fix #22845, fix #22219
@MorrisJobke MorrisJobke added this to the Nextcloud 20 milestone Sep 18, 2020
backportbot-nextcloud bot pushed a commit that referenced this issue Sep 18, 2020
skjnldsv added a commit that referenced this issue Sep 18, 2020
[stable20] Make sure most app names don’t ellipsize, fix #22845, fix #22219
@rullzer rullzer mentioned this issue Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants