Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard design enhancements #22143

Merged
merged 7 commits into from
Aug 11, 2020
Merged

Dashboard design enhancements #22143

merged 7 commits into from
Aug 11, 2020

Conversation

jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Aug 7, 2020

  • We should add the ability that people can customize their background. This could be done via the "Edit widgets" modal. (There we can also properly credit the pictures.)
  • We can collect some default backgrounds, possibly some from our example files and/or some new ones. :)
  • Adjust backgrounds so they work with dark theme too (needed to use custom values as our variables don’t use rgb and thus can not be made partly transparent)
  • Nice fancy blur/transparency effect for the hover/focus effect of the widget entries would be nice too, instead of just grey
  • We need to make sure the navigation icons and heading text works on other types of background images too.
  • The "Edit widgets" button should also use the same background+blur style.
  • Some better loading feedback than the white space. Ideally already show skeleton content, background color, etc.

Note that Firefox unfortunately does not support the blur effect on the panels …
Dashboard design

Dashboard design dark

@jancborchardt jancborchardt added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 10, 2020
@jancborchardt
Copy link
Member Author

This is ready for review, the additional things can be done in follow-ups. :)

@juliushaertl
Copy link
Member

@jancborchardt I'd say we can get this in once the remaining small comment is fixed and do the custom background in a follow up.

@jancborchardt
Copy link
Member Author

@jancborchardt I'd say we can get this in once the remaining small comment is fixed and do the custom background in a follow up.

All done and ready to go.

@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
57 tasks
@jancborchardt
Copy link
Member Author

Added the outstanding points to the overview issue at #20930, this is ready to merge :)

@jancborchardt
Copy link
Member Author

Will add credit first!

Signed-off-by: Jan C. Borchardt <[email protected]>
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, working good. We will also need to add credits for weather.

apps/dashboard/src/App.vue Show resolved Hide resolved
@faily-bot
Copy link

faily-bot bot commented Aug 11, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31629: failure

mysql8.0-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Storage\Wrapper\QuotaTest::testNoTouchQuotaZero
Failed asserting that true is false.

/drone/src/tests/lib/Files/Storage/Wrapper/QuotaTest.php:219

mysql5.6-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\CacheTest::testWithoutNormalizer
Failed asserting that 0 is greater than 0.

/drone/src/tests/lib/Files/Cache/CacheTest.php:550

@jancborchardt
Copy link
Member Author

@juliushaertl said failures look unrelated, so let’s get it in!

@jancborchardt jancborchardt merged commit 50fdd45 into master Aug 11, 2020
@jancborchardt jancborchardt deleted the design/dashboard-design branch August 11, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants