fix(update-section): changed span to an interactive element #42744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emoral435
requested review from
susnux,
JuliaKirschenheuter,
Pytal and
ShGKme
|
/backport to stable28 |
ShGKme
reviewed
Jan 12, 2024
| @@ -85,7 +85,7 @@ | |||
| </template> | |||
| <template v-else> | |||
| {{ t('updatenotification', 'Your version is up to date.') }} | |||
| <span :title="lastCheckedOnString" :aria-label="lastCheckedOnString" class="icon-info svg" /> | |||
| <a :title="lastCheckedOnString" :aria-label="lastCheckedOnString" href="https://nextcloud.com/changelog/" class="icon-info details"></a> | |||
There was a problem hiding this comment.
I think, it should be target="_blank", same as the second one is
Pytal
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Could you please add aria-label to all links for following pages:
- settings/user/sharing - aria-label
- settings/user/workflow
- settings/admin/overview
- settings/admin
- settings/admin/sharing
- settings/admin/security
- settings/admin/theming
- settings/admin/groupware
- settings/admin/admindelegation
- settings/admin/workflow
Signed-off-by: Eduardo Morales <[email protected]>
emoral435
force-pushed
the
fix/updatenotification/42637/move-title-and-aria-label-to-interactive-element
branch
from
7ad8387
to
a671c51
Compare
|
Because some of those issues need changes from other libraries, im splitting this issue into another issue @JuliaKirschenheuter , but I will still work on it right now :) all this needs now is a re-review ! |
ShGKme
approved these changes
Jan 16, 2024
Pytal
added
4. to release
Pytal
deleted the
fix/updatenotification/42637/move-title-and-aria-label-to-interactive-element
branch
|
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
* Resolves: #42637
Summary
Changes span to a link element, similar to how the above information button is like within the page!
Checklist