Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the filemodel before rending the detailsview #12231

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Set the filemodel before rending the detailsview #12231

merged 1 commit into from
Nov 5, 2018

Commits on Nov 2, 2018

  1. Set the filemodel before rending the detailsview 

    fixes #10934

Else it triggers the rendering two times. Resulting is weird state in
for example the comments. Because the comments for OLD_FILEID are
retrieved but then the model is changed to NEW_FILEID. But the old
comments still get in and get parsed.

Signed-off-by: Roeland Jago Douma <[email protected]>
    @rullzer
    rullzer committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    b1fd72c View commit details
    Browse the repository at this point in the history