-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade eslint-config to v6.0.0 #28019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the breath of fresh air space !
- add required dev dependencies Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Needs a rebase after #28115 🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eslint-config v6 requires webpack 5.
https://github.com/nextcloud/eslint-config/blob/70e5f6d03d4d606c394be1dd7c570fef4497d681/package.json#L22
Seems like this has been done somewhere else already, therefore closing ;) |
Pending migration to
@nextcloud/webpack-vue-config
and webpack 5Upgrade @nextcloud/eslint-config to v6.0.0, latest major :)